From: Junio C Hamano <gitster@pobox•com>
To: Johannes Sixt <j6t@kdbg•org>
Cc: Stefan Beller <sbeller@google•com>,
jrnieder@gmail•com, git@vger•kernel.org
Subject: Re: [PATCH] t7406: submodule.<name>.update command must not be run from .gitmodules
Date: Tue, 26 Sep 2017 15:28:21 +0900 [thread overview]
Message-ID: <xmqqshfa9doa.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <0aa754b4-93fb-3f23-be51-4af5227ac847@kdbg.org> (Johannes Sixt's message of "Tue, 26 Sep 2017 07:37:30 +0200")
Johannes Sixt <j6t@kdbg•org> writes:
>> + test_when_finished "git -C super reset --hard HEAD^" &&
>> +
>> + write_script must_not_run.sh <<-EOF &&
>> + >$TEST_DIRECTORY/bad
>> + EOF
>
> I am pretty confident that this does not test what you intend to
> test. Notice that $TEST_DIRECTORY is expanded when the script is
> written. But that path contains a blank, and we have something like
> this in the test script:
>
> #!/bin/sh
> >/the/build/directory/t/trash directory.t7406/bad
Nicely explained. Thanks.
next prev parent reply other threads:[~2017-09-26 6:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 19:55 [PATCH] t7406: submodule.<name>.update command must not be run from .gitmodules Stefan Beller
2017-09-25 20:04 ` Jonathan Nieder
2017-09-25 22:50 ` Stefan Beller
2017-09-26 0:01 ` Jonathan Nieder
2017-09-26 5:37 ` Johannes Sixt
2017-09-26 6:28 ` Junio C Hamano [this message]
2017-09-26 18:54 ` Stefan Beller
2017-09-26 19:46 ` Johannes Sixt
2017-09-26 19:54 ` Stefan Beller
2017-09-27 3:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshfa9doa.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=jrnieder@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox