From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH v4 4/4] convert: add "status=delayed" to filter process protocol
Date: Tue, 30 May 2017 10:03:37 +0900 [thread overview]
Message-ID: <xmqqshjndul2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <832A4D04-F32F-4D1F-A5CE-3514F8469E63@gmail.com> (Lars Schneider's message of "Mon, 29 May 2017 13:11:55 +0200")
Lars Schneider <larsxschneider@gmail•com> writes:
>> That's right. There might be some code sharing opportunity with Ben's
>> code that is already in "next":
>> https://github.com/git/git/blob/next/convert.c#L660-L677
>>
>> Would it be useful for you if I send v5 with the changes rebased
>> onto "next"?
>
> Hi Junio,
>
> sorry for bugging you again, but Ben's topic did not make it to "master"
> today. Is it OK if I rebase my topic onto "next" and resend?
Sorry, your earlier question was lost in the noise and I should have
picked it up during my last sweep of leftover bits.
If you are depending on a single topic in 'next', it is better to
build on the tip of that topic, not on 'next', if you can figure out
where the tip is. In practice, while we are exchanging patches via
e-mail, there should be no noticeable difference either way [*1*],
but once you start throwing a complex and long series, you may want
to publish it to a public repository for reviewers and the
maintainer to pull, and that workflow might give us an easier way to
review, but a topic based on 'next' will never have a chance to be
pulled to be merged for real, as merging its tip to 'master' means
it will bring all other junk that may not ready. So if you anticipate
that to happen someday, practicing to build on things that are only
needed (e.g. if you depend on two topics, you may start by merging
them on top of 'master' and then building your change on top) is a
good idea.
No matter what you do, please mention on top of what you built your
work.
Thanks.
next prev parent reply other threads:[~2017-05-30 1:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:49 [PATCH v4 0/4] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-05-22 13:49 ` [PATCH v4 1/4] t0021: keep filter log files on comparison Lars Schneider
2017-05-22 13:49 ` [PATCH v4 2/4] t0021: make debug log file name configurable Lars Schneider
2017-05-22 13:50 ` [PATCH v4 3/4] t0021: write "OUT" only on success Lars Schneider
2017-05-22 13:50 ` [PATCH v4 4/4] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-05-22 19:30 ` Taylor Blau
2017-05-22 19:52 ` Torsten Bögershausen
2017-05-22 20:33 ` Lars Schneider
2017-05-22 19:58 ` Torsten Bögershausen
2017-05-22 20:37 ` Lars Schneider
2017-05-23 5:22 ` Junio C Hamano
2017-05-23 8:43 ` Lars Schneider
2017-05-29 11:11 ` Lars Schneider
2017-05-30 1:03 ` Junio C Hamano [this message]
2017-05-30 1:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshjndul2.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox