Subject: Re: [PATCH 22/29] blame: create scoreboard setup function

From: Junio C Hamano <[email-masked]>
Date: Thu, 25 May 2017 14:15:48 +0900

Jeff Smith <[email-masked]> writes:

> Create function that completes setting up blame_scoreboard structure.
>
> Signed-off-by: Jeff Smith <[email-masked]>
> ---
>  builtin/blame.c | 190 ++++++++++++++++++++++++++++++--------------------------
>  1 file changed, 101 insertions(+), 89 deletions(-)
>
> diff --git a/builtin/blame.c b/builtin/blame.c
> index f839571..fd41551 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> ...
> @@ -2759,92 +2855,8 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
> ...
> -	sb.num_read_blob++;
> -	lno = prepare_lines(&sb);
> +	setup_scoreboard(&sb, path, &o);
> +	lno = sb.num_lines;
>  
>  	if (lno && !range_list.nr)
>  		string_list_append(&range_list, "1");

After this change, nobody uses the value returned from
prepare_ilnes(), but the function is still returning an "int".
Perhaps change it to return nothing?