From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: j6t@kdbg•org, Johannes.Schindelin@gmx•de, git@vger•kernel.org,
venv21@gmail•com, dennis@kaarsemaker•net, jrnieder@gmail•com
Subject: Re: [PATCHv3] submodule--helper: normalize funny urls
Date: Tue, 18 Oct 2016 14:19:12 -0700 [thread overview]
Message-ID: <xmqqshrtnynj.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqzim1nyz0.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Tue, 18 Oct 2016 14:12:19 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Stefan Beller <sbeller@google•com> writes:
>
>> The remote URL for the submodule can be specified relative
>> ...
>> v3:
>> * fixed the coding style.
>
> Ah, thanks. I had a squash queued on top but will replace with this
> one.
Heh, I guess I shouldn't have responded before seeing what this
breaks. Applied on top of sb/submodule-ignore-trailing-slash, these
seem to break.
t/trash directory.t3600-rm
t/trash directory.t7403-submodule-sync
t/trash directory.t7406-submodule-update
t/trash directory.t7407-submodule-foreach
t/trash directory.t7506-status-submodule
Some may be showing broken assumptions of the downstream, two wrongs
compensating each other and correcting one exposing breakage of the
other. I didn't look at them deeply.
next prev parent reply other threads:[~2016-10-18 21:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 21:06 [PATCHv3] submodule--helper: normalize funny urls Stefan Beller
2016-10-18 21:12 ` Junio C Hamano
2016-10-18 21:19 ` Junio C Hamano [this message]
2016-10-18 23:25 ` Stefan Beller
2016-10-19 0:56 ` Junio C Hamano
2016-10-19 1:04 ` Stefan Beller
2016-10-19 2:05 ` Junio C Hamano
2016-10-20 19:15 ` Stefan Beller
2016-10-20 19:26 ` Junio C Hamano
2016-10-20 19:34 ` Stefan Beller
2016-10-20 19:53 ` Junio C Hamano
2016-10-21 20:56 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshrtnynj.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=dennis@kaarsemaker$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=jrnieder@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
--cc=venv21@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox