From: Junio C Hamano <gitster@pobox•com>
To: Edward Thomson <ethomson@edwardthomson•com>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [PATCH] upload-pack: keep poll(2)'s timeout to -1
Date: Fri, 22 Aug 2014 11:26:51 -0700 [thread overview]
Message-ID: <xmqqsikonzx0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140822162711.GA8598@debian> (Edward Thomson's message of "Fri, 22 Aug 2014 16:27:11 +0000")
Edward Thomson <ethomson@edwardthomson•com> writes:
> On Fri, Aug 22, 2014 at 12:03:34PM -0400, Jeff King wrote:
>>
>> Yeah, I wasn't thinking we would get negative values from the user (we
>> don't document them at all), but we should probably do something
>> sensible. Let's just leave it at Ed's patch.
>
> Thanks, both. Apologies for the dumb question: is there anything
> additional that I need to do (repost with your Acked-by, for example)
> or is this adequate as-is?
I've picked it up and queued it on 'pu'. Thanks.
commit 6c71f8b0d3d39beffe050f92f33a25dc30dffca3
Author: Edward Thomson <ethomson@edwardthomson•com>
Date: Fri Aug 22 15:19:11 2014 +0000
upload-pack: keep poll(2)'s timeout to -1
Keep poll's timeout at -1 when uploadpack.keepalive = 0, instead of
setting it to -1000, since some pedantic old systems (eg HP-UX) and
the gnulib compat/poll will treat only -1 as the valid value for
an infinite timeout.
Signed-off-by: Edward Thomson <ethomson@microsoft•com>
Acked-by: Jeff King <peff@peff•net>
Signed-off-by: Junio C Hamano <gitster@pobox•com>
next prev parent reply other threads:[~2014-08-22 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 15:19 [PATCH] upload-pack: keep poll(2)'s timeout to -1 Edward Thomson
2014-08-22 15:44 ` Jeff King
2014-08-22 15:56 ` Junio C Hamano
2014-08-22 16:03 ` Jeff King
2014-08-22 16:27 ` Edward Thomson
2014-08-22 18:26 ` Junio C Hamano [this message]
2014-08-22 18:19 ` Junio C Hamano
2014-08-22 18:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsikonzx0.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=ethomson@edwardthomson$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox