From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Jonathan Nieder <jrnieder@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] shell doc: remove stray "+" in example
Date: Thu, 08 May 2014 10:26:41 -0700 [thread overview]
Message-ID: <xmqqsiok41wu.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140508040438.GB26630@sigill.intra.peff.net> (Jeff King's message of "Thu, 8 May 2014 00:04:38 -0400")
Jeff King <peff@peff•net> writes:
> On Wed, May 07, 2014 at 04:44:01PM -0700, Jonathan Nieder wrote:
>
>> The git-shell(1) manpage says
>>
>> EXAMPLE
>> To disable interactive logins, displaying a greeting
>> instead:
>>
>> +
>>
>> $ chsh -s /usr/bin/git-shell
>> $ mkdir $HOME/git-shell-commands
>> [...]
>>
>> The stray "+" has been there ever since the example was added in
>> v1.8.3-rc0~210^2 (shell: new no-interactive-login command to print a
>> custom message, 2013-03-09). The "+" sign between paragraphs is
>> needed in asciidoc to attach extra paragraphs to a list item but here
>> it is not needed and ends up rendered as a literal "+". Remove it.
>>
>> A quick search with "grep -e '<p>+' /usr/share/doc/git/html/*.html"
>> doesn't find any other instances of this problem.
>>
>> Signed-off-by: Jonathan Nieder <jrnieder@gmail•com>
>
> Looks good to me. I suspect it was copied from another spot where the
> examples _were_ in a list (e.g., git-add's EXAMPLES section). Either
> way, your fix is the right thing to do.
Thanks, both. Looks good to me, too.
prev parent reply other threads:[~2014-05-08 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 23:44 [PATCH] shell doc: remove stray "+" in example Jonathan Nieder
2014-05-08 4:04 ` Jeff King
2014-05-08 17:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsiok41wu.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox