From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Ilya Bobyr <ilya.bobyr@gmail•com>, Git List <git@vger•kernel.org>,
Jonathan Nieder <jrnieder@gmail•com>,
Thomas Rast <tr@thomasrast•ch>
Subject: Re: [PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so
Date: Mon, 03 Mar 2014 15:13:39 -0800 [thread overview]
Message-ID: <xmqqsiqynae4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cQgYOz7rDax=HFNG9mr-H1FaoL-ss2mgdpMazPS4pWbNQ@mail.gmail.com> (Eric Sunshine's message of "Mon, 3 Mar 2014 17:59:15 -0500")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Mon, Mar 3, 2014 at 5:24 AM, Ilya Bobyr <ilya.bobyr@gmail•com> wrote:
>> We used to show "(missing )" next to tests skipped because they are
>> specified in GIT_SKIP_TESTS. Use "(matched by GIT_SKIP_TESTS)" instead.
>
> Bikeshedding: That's pretty verbose. Perhaps just say "(excluded)"?
Sounds good, or at least better than matched GIT_SKIP_TESTS, to me ;-).
Thanks.
next prev parent reply other threads:[~2014-03-03 23:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 10:24 [PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so Ilya Bobyr
2014-03-03 10:24 ` [PATCH 2/2] test-lib: GIT_TEST_ONLY to run only specific tests Ilya Bobyr
2014-03-03 15:56 ` Philip Oakley
2014-03-03 23:03 ` Eric Sunshine
2014-03-03 23:16 ` Ilya Bobyr
2014-03-03 23:26 ` Junio C Hamano
2014-03-03 23:48 ` Ilya Bobyr
2014-03-04 0:08 ` Junio C Hamano
2014-03-04 7:06 ` Ilya Bobyr
2014-03-04 8:29 ` Junio C Hamano
2014-03-04 9:18 ` Ilya Bobyr
2014-03-04 19:01 ` Junio C Hamano
2014-03-03 15:11 ` [PATCH 1/2] test-lib: tests skipped by GIT_SKIP_TESTS say so Philip Oakley
2014-03-03 23:08 ` Ilya Bobyr
2014-03-03 22:59 ` Eric Sunshine
2014-03-03 23:12 ` Ilya Bobyr
2014-03-03 23:13 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-03 23:18 Eric Sunshine
2014-03-03 23:39 ` Junio C Hamano
2014-03-03 23:50 ` Ilya Bobyr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsiqynae4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ilya.bobyr@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tr@thomasrast$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox