From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Jonathan Nieder <jrnieder@gmail•com>,
Git List <git@vger•kernel.org>,
Joshua Jensen <jjensen@workspacewhiz•com>,
Brian Gernhardt <brian@gernhardtsoftware•com>
Subject: Re: [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/'
Date: Sun, 25 Aug 2013 22:38:29 -0700 [thread overview]
Message-ID: <xmqqsixxj9ka.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cSY8oMeAaS2GRaPhwCkfO=eLa6-UPcJGRe98c0uUFbm8Q@mail.gmail.com> (Eric Sunshine's message of "Sun, 25 Aug 2013 04:05:30 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> ... A
> follow-up series [2] fixes both directory_exists_in_index() and
> directory_exists_in_index_icase() to be more liberal in what they
> accept, relieving the caller of the burden. By the time that series
> was posted, however, Junio and Peff had decided that a fix at a more
> fundamental level would be better (a conclusion with which I agree,
Thanks for a summary; the last "would be better" is a qualified one,
though.
My understanding is that we agreed that it would be better *if* we
can fix it at a more fundamental level. I looked at the codepaths
involved just enough to make that off the cuff suggestion and no
deeper than that, and I suspect neither did Peff.
If any of us looked at the problem deep enough, we may realize that
it would affect too many things, and $gmane/232833/focus=232835
(your second round) may turn out to be a better solution. I think
none of us know yet.
prev parent reply other threads:[~2013-08-26 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 4:29 [PATCH 0/2] fix t3010 failure when core.ignorecase=true Eric Sunshine
2013-08-23 4:29 ` [PATCH 1/2] t3103: demonstrate dir.c:treat_one_path() core.ignorecase failure Eric Sunshine
2013-08-23 17:21 ` Junio C Hamano
2013-08-23 4:29 ` [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/' Eric Sunshine
2013-08-25 6:00 ` Jonathan Nieder
2013-08-25 8:05 ` Eric Sunshine
2013-08-26 5:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsixxj9ka.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=brian@gernhardtsoftware$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jjensen@workspacewhiz$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox