From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Paul Tarjan <paul@paultarjan•com>,
phillip.wood@dunelm•org.uk,
Paul Tarjan via GitGitGadget <gitgitgadget@gmail•com>,
git@vger•kernel.org, Paul Tarjan <github@paulisageek•com>
Subject: Re: [PATCH v2] t7800: fix racy "difftool --dir-diff syncs worktree" test
Date: Sun, 04 Jan 2026 11:27:27 +0900 [thread overview]
Message-ID: <xmqqtsx2p0xc.fsf@gitster.g> (raw)
In-Reply-To: <1e39f5d3-6b4a-f832-8328-f82ece12deff@gmx.de> (Johannes Schindelin's message of "Sat, 3 Jan 2026 21:29:45 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
> Hi Paul,
>
> On Sat, 3 Jan 2026, Paul Tarjan wrote:
>
>> I've updated the commit and PR summary for your comments. Should I
>> re-run /submit to send a no-op patch or leave it as is until code
>> changes are needed?
>
> I believe that the change you intended for v2 (adding the "Reviewed-by"
> trailer) accidentally made it to the cover letter only, not to the commit
> message where it wants to live.
>
> Also, I would like to suggest to replace the non-URL
> "git-for-windows/git#5132" with the actual URL:
> https://github.com/git-for-windows/git/issues/5132. Remember: Commit
> messages are not usually read on GitHub (and some very vocal Git
> contributors actually refuse to use GitHub for their contributions).
Both good suggestions.
next prev parent reply other threads:[~2026-01-04 2:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 22:19 [PATCH] t7800: fix racy "difftool --dir-diff syncs worktree" test Paul Tarjan via GitGitGadget
2026-01-01 14:49 ` Johannes Schindelin
2026-01-01 18:27 ` [PATCH v2] " Paul Tarjan via GitGitGadget
2026-01-01 22:49 ` Junio C Hamano
2026-01-03 9:39 ` Phillip Wood
2026-01-03 16:30 ` Paul Tarjan
2026-01-03 20:29 ` Johannes Schindelin
2026-01-04 2:27 ` Junio C Hamano [this message]
2026-01-03 20:40 ` [PATCH v3] " Paul Tarjan via GitGitGadget
2026-01-04 2:34 ` Junio C Hamano
2026-01-05 10:33 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsx2p0xc.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=github@paulisageek$(echo .)com \
--cc=paul@paultarjan$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox