From: Junio C Hamano <gitster@pobox•com>
To: "Keller, Jacob E" <jacob.e.keller@intel•com>
Cc: Collin Funk <collin.funk1@gmail•com>,
"git@vger•kernel.org" <git@vger•kernel.org>,
"jn.avila@free•fr" <jn.avila@free•fr>,
Corentin Garcia <corenting@gmail•com>
Subject: Re: [PATCH v3] completion: make sed command that generates config-list.h portable.
Date: Mon, 02 Jun 2025 17:17:52 -0700 [thread overview]
Message-ID: <xmqqtt4xsmof.fsf@gitster.g> (raw)
In-Reply-To: <CO1PR11MB508935F77DB5D7CA29BF8D79D662A@CO1PR11MB5089.namprd11.prod.outlook.com> (Jacob E. Keller's message of "Mon, 2 Jun 2025 23:05:20 +0000")
"Keller, Jacob E" <jacob.e.keller@intel•com> writes:
>> -----Original Message-----
>> From: Collin Funk <collin.funk1@gmail•com>
>> Sent: Monday, June 2, 2025 3:32 PM
>> To: git@vger•kernel.org
>> Cc: jn.avila@free•fr; Keller, Jacob E <jacob.e.keller@intel•com>; Collin Funk
>> <collin.funk1@gmail•com>; Corentin Garcia <corenting@gmail•com>; Junio C
>> Hamano <gitster@pobox•com>
>> Subject: [PATCH v3] completion: make sed command that generates config-list.h
>> portable.
>>
>> The OpenBSD 'sed' command does not support '\n' to represent newlines in
>> sed expressions. This leads to the follow compiler error:
>>
>> In file included from builtin/help.c:15:
>> ./config-list.h:282:18: error: use of undeclared identifier 'n'
>> "gitcvs.dbUser",n "gitcvs.dbPass",
>> ^
>> 1 error generated.
>> gmake: *** [Makefile:2821: builtin/help.o] Error 1
>>
>> We can fix this by documenting related configuration variables
>> one-per-line instead of listing them separated by commas. This allows us
>> to remove the unportable part of the sed expression in
>> generate-configlist.sh.
>>
>> Signed-off-by: Collin Funk <collin.funk1@gmail•com>
>> ---
>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel•com>
Thanks, all.
prev parent reply other threads:[~2025-06-03 0:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 18:41 [PATCH] completion: Make sed command that generates config-list.h portable Collin Funk
2025-06-02 19:05 ` Brad Smith
2025-06-02 19:05 ` Jean-Noël AVILA
2025-06-02 19:20 ` Collin Funk
2025-06-02 19:26 ` [PATCH v2] " Collin Funk
2025-06-02 19:49 ` Jean-Noël AVILA
2025-06-02 20:08 ` Collin Funk
2025-06-02 21:42 ` Jacob Keller
2025-06-02 22:35 ` Collin Funk
2025-06-03 0:21 ` Junio C Hamano
2025-06-03 0:49 ` [PATCH] CodingGuidelines: document formatting required by generate-configlist.sh Collin Funk
2025-06-03 14:54 ` Junio C Hamano
2025-06-03 18:56 ` Collin Funk
2025-06-03 20:43 ` Junio C Hamano
2025-06-03 22:49 ` Collin Funk
2025-06-03 22:45 ` [PATCH v2] CodingGuidelines: document formatting of similar config variables Collin Funk
2025-06-03 23:57 ` Junio C Hamano
2025-06-02 22:31 ` [PATCH v3] completion: make sed command that generates config-list.h portable Collin Funk
2025-06-02 23:05 ` Keller, Jacob E
2025-06-03 0:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtt4xsmof.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=collin.funk1@gmail$(echo .)com \
--cc=corenting@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jn.avila@free$(echo .)fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox