Subject: Re: [PATCH v6 3/6] set-head: better output for --auto

From: Junio C Hamano <[email-masked]>
Date: Fri, 11 Oct 2024 09:31:26 -0700

"Bence Ferdinandy" <[email-masked]> writes:

> Thanks for the very helpful review on the series! Most of it is clear to me and
> I agree with, so for brevity I'll only comment where I have a question/comment.
>
> On Thu Oct 10, 2024 at 23:05, karthik nayak <[email-masked]> wrote:
> [snip]
>
>> > diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
>> > index 532035933f..77c12b8709 100755
>> > --- a/t/t5505-remote.sh
>> > +++ b/t/t5505-remote.sh
>> > @@ -429,12 +429,51 @@ test_expect_success 'set-head --auto' '
>> >  	)
>> >  '
>> >
>> > +test_expect_success 'set-head --auto detects creation' '
>> > +	(
>> > +		cd test &&
>> > +		rm .git/refs/remotes/origin/HEAD &&
>>
>> does this work with reftables too?
>
> You got me there, probably not. I'm guessing I should use git update-ref or
> something similar to set these values manually instead of editing the file.

Yup, "git update-ref --no-deref -d refs/remotes/origin/HEAD"

> On the other hand, is there a way to force the tests to run on a reftables
> backend? t/README does not mention anything about this and since in a previous
> round it already came up that I forgot to update the reftables backend, it
> would be nice if I could actually test everything with that as well.

$ git grep GIT_TEST_DEFAULT_REF_FORMAT t/README

Thanks.