From: Junio C Hamano <gitster@pobox•com>
To: Robert Stanca <robert.stanca7@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags
Date: Sat, 01 Apr 2017 12:13:38 -0700 [thread overview]
Message-ID: <xmqqtw68szz1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170401153049.21400-2-robert.stanca7@gmail.com> (Robert Stanca's message of "Sat, 1 Apr 2017 18:30:49 +0300")
Robert Stanca <robert.stanca7@gmail•com> writes:
> As rev_list_info's flag is unsigned int , var flags should have proper type.Also var cnt could be unsigned as there's no negative number of commits (all-reaches)
>
> Signed-off-by: Robert Stanca <robert.stanca7@gmail•com>
> ---
OK. I would have squashed these two commits into one, though.
next prev parent reply other threads:[~2017-04-01 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 15:30 [PATCH 1/2] [GSOC] Convert signed flags to unsigned Robert Stanca
2017-04-01 15:30 ` [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags Robert Stanca
2017-04-01 19:13 ` Junio C Hamano [this message]
2017-04-01 19:19 ` Robert Stanca
2017-04-02 3:30 ` Junio C Hamano
2017-04-02 13:18 ` Robert Stanca
2017-04-02 17:14 ` Junio C Hamano
2017-04-01 19:12 ` [PATCH 1/2] [GSOC] Convert signed flags to unsigned Junio C Hamano
2017-04-01 19:30 ` Robert Stanca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw68szz1.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=robert.stanca7@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox