From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Johannes Sixt <j6t@kdbg•org>,
git@vger•kernel.org
Subject: Re: What's cooking in git.git (Jan 2017, #02; Sun, 15)
Date: Tue, 17 Jan 2017 12:32:26 -0800 [thread overview]
Message-ID: <xmqqtw8xe8bp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170117193639.mt3x3md3nbh2qgws@sigill.intra.peff.net> (Jeff King's message of "Tue, 17 Jan 2017 14:36:39 -0500")
Jeff King <peff@peff•net> writes:
> That was my general impression, too. But I seem to recall it was you in
> a nearby thread saying that:
>
> if (foo)
> bar();
> else {
> one();
> two();
> }
>
> was wrong. Maybe I misunderstood.
If it were a new code written like the above, that would have been
fine. If a new code written with both sides inside {}, that would
have been fine, too.
IIRC, it was that the original had {} on both, and a patch tried to
turn that into the above, triggering "why are we churning between
two acceptable forms?"
next prev parent reply other threads:[~2017-01-17 20:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 1:51 What's cooking in git.git (Jan 2017, #02; Sun, 15) Junio C Hamano
2017-01-16 6:56 ` Johannes Sixt
2017-01-16 7:48 ` Junio C Hamano
2017-01-16 12:52 ` Johannes Schindelin
2017-01-16 16:04 ` Jeff King
2017-01-16 17:06 ` Johannes Schindelin
2017-01-16 20:33 ` Johannes Sixt
2017-01-16 21:44 ` Jeff King
2017-01-17 19:17 ` Junio C Hamano
2017-01-18 6:50 ` Johannes Sixt
2017-01-18 19:12 ` Junio C Hamano
2017-01-19 16:12 ` Johannes Schindelin
2017-01-16 22:00 ` Jeff King
2017-01-16 22:08 ` [PATCH] CodingGuidelines: clarify multi-line brace style Jeff King
2017-01-17 19:39 ` Junio C Hamano
2017-01-17 20:05 ` Jeff King
2017-01-17 21:41 ` Junio C Hamano
2017-01-17 1:33 ` What's cooking in git.git (Jan 2017, #02; Sun, 15) Jacob Keller
2017-01-17 7:52 ` Jeff King
2017-01-17 19:20 ` Junio C Hamano
2017-01-17 19:36 ` Jeff King
2017-01-17 20:32 ` Junio C Hamano [this message]
2017-01-17 20:51 ` Jeff King
2017-01-16 11:28 ` Johannes Schindelin
2017-01-17 19:45 ` Junio C Hamano
2017-01-18 13:54 ` Johannes Schindelin
2017-01-16 11:40 ` Johannes Schindelin
2017-01-18 1:05 ` [PATCHv3 4/4] unpack-trees: support super-prefix option Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw8xe8bp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox