From: Junio C Hamano <gitster@pobox•com>
To: Steven Penny <svnpenn@gmail•com>,
Johannes Schindelin <johannes.schindelin@gmx•de>,
Johannes Sixt <j6t@kdbg•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Makefile: POSIX windres
Date: Sun, 08 Jan 2017 19:10:41 -0800 [thread overview]
Message-ID: <xmqqtw99x70u.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170107214110.3124-1-svnpenn@gmail.com> (Steven Penny's message of "Sat, 7 Jan 2017 15:41:10 -0600")
Steven Penny <svnpenn@gmail•com> writes:
> When environment variable POSIXLY_CORRECT is set, the "input -o output" syntax
> is not supported.
>
> http://cygwin.com/ml/cygwin/2017-01/msg00036.html
>
> Signed-off-by: Steven Penny <svnpenn@gmail•com>
> ---
Who other than cygwin build uses this target? Git for Windows?
Hannes, Dscho, is this change OK with you guys?
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d861bd9..a2a1212 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1816,7 +1816,7 @@ $(SCRIPT_LIB) : % : %.sh GIT-SCRIPT-DEFINES
> git.res: git.rc GIT-VERSION-FILE
> $(QUIET_RC)$(RC) \
> $(join -DMAJOR= -DMINOR=, $(wordlist 1,2,$(subst -, ,$(subst ., ,$(GIT_VERSION))))) \
> - -DGIT_VERSION="\\\"$(GIT_VERSION)\\\"" $< -o $@
> + -DGIT_VERSION="\\\"$(GIT_VERSION)\\\"" -i $< -o $@
>
> # This makes sure we depend on the NO_PERL setting itself.
> $(SCRIPT_PERL_GEN): GIT-BUILD-OPTIONS
next prev parent reply other threads:[~2017-01-09 3:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 21:41 [PATCH] Makefile: POSIX windres Steven Penny
2017-01-09 3:10 ` Junio C Hamano [this message]
2017-01-09 8:09 ` Johannes Schindelin
2017-01-09 9:47 ` Junio C Hamano
2017-01-09 19:54 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw99x70u.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=svnpenn@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox