public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Luke Diamand <luke@diamand•org>
Cc: "Amadeusz Żołnowski" <aidecoe@aidecoe•name>,
	"Git Users" <git@vger•kernel.org>
Subject: Re: [PATCH] git-p4.py: Make submit working on bare repository
Date: Tue, 12 Apr 2016 16:25:33 -0700	[thread overview]
Message-ID: <xmqqtwj6mmtu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAE5ih7-q_PwF-T6nsu=FyyN9wO6o0Jcfkg=gKy5mhOXRGFZ+VA@mail.gmail.com> (Luke Diamand's message of "Mon, 29 Feb 2016 15:29:02 +0000")

Luke Diamand <luke@diamand•org> writes:

> On 28 February 2016 at 20:46, Amadeusz Żołnowski <aidecoe@aidecoe•name> wrote:
>
>>
>> True. For now I have these cases covered by wrapper scripts. The minimum
>> I need from git-p4 is just not to fail on git submit from bare
>> repository which is covered by patch I have submitted. If I get my
>> solution enough testing, I'd think of transforming it into patch for
>> git-p4.py as well.
>
> Could you change the patch to add a command-line option to suppress
> the rebase? I think this would be a bit more obvious: instead of
> having some special magical behaviour kick-in on a bare repo, git-p4
> just does what it's told on the command-line.
>
> It means that if we find another situation where we don't want to
> rebase, we don't have an ever-growing list of special-case
> circumstances, which could become hard to make sense of in future.
> Instead, the user (who hopefully knows better) just tells git-p4 what
> to do.

Has anything happened to this topic after this?  I am wondering if I
should discard the topic az/p4-bare-no-rebase without prejudice.

Thanks.

next prev parent reply	other threads:[~2016-04-12 23:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 22:46 [PATCH] git-p4.py: Don't try to rebase on submit from bare repository Amadeusz Żołnowski
2016-02-19  9:47 ` Luke Diamand
2016-02-19 17:21   ` Junio C Hamano
2016-02-19 18:27     ` Amadeusz Żołnowski
2016-02-19 18:40       ` Eric Sunshine
2016-02-19 21:57         ` [PATCH] git-p4.py: Make submit working on " Amadeusz Żołnowski
2016-02-19 22:44           ` Junio C Hamano
2016-02-20 11:00             ` Amadeusz Żołnowski
2016-02-21  7:36               ` Junio C Hamano
2016-02-22 18:50                 ` Amadeusz Żołnowski
2016-02-23  6:59                   ` Junio C Hamano
2016-02-23 12:05                     ` Luke Diamand
2016-02-23 20:56                       ` Amadeusz Żołnowski
2016-02-28  4:26                         ` Luke Diamand
2016-02-28 20:46                           ` Amadeusz Żołnowski
2016-02-29 15:29                             ` Luke Diamand
2016-04-12 23:25                               ` Junio C Hamano [this message]
2016-04-13 20:27                                 ` Amadeusz Żołnowski
2016-04-13 21:47                                   ` Junio C Hamano
2016-06-07 20:32                                     ` Amadeusz Żołnowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtwj6mmtu.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=aidecoe@aidecoe$(echo .)name \
    --cc=git@vger$(echo .)kernel.org \
    --cc=luke@diamand$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox