public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Romain Picard <romain.picard@oakbits•com>
Cc: git@vger•kernel.org, luke@diamand•org, larsxschneider@gmail•com,
	sunshine@sunshineco•com, git-owner@vger•kernel.org
Subject: Re: [PATCH v2] git-p4.py: add support for filetype change
Date: Mon, 04 Jan 2016 13:55:16 -0800	[thread overview]
Message-ID: <xmqqtwmtm2m3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1451904764-338-1-git-send-email-romain.picard@oakbits.com> (Romain Picard's message of "Mon, 4 Jan 2016 11:52:44 +0100")

Romain Picard <romain.picard@oakbits•com> writes:

> diff --git a/t/t9827-git-p4-change-filetype.sh b/t/t9827-git-p4-change-filetype.sh
> new file mode 100755
> index 0000000..b0a9f62
> --- /dev/null
> +++ b/t/t9827-git-p4-change-filetype.sh
> @@ -0,0 +1,69 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2016 Romain Picard
> +#
> +
> +test_description='git p4 support for file type change'
> +
> +. ./lib-git-p4.sh
> +
> +test_expect_success 'start p4d' '
> +	start_p4d
> +'
> +
> +test_expect_success 'create files' '
> +	(
> +		cd "$cli" &&
> +		p4 client -o | sed "/LineEnd/s/:.*/:unix/" | p4 client -i &&
> +		cat >file1 <<-EOF &&
> +		This is a first file.
> +		EOF
> +		cat >file2 <<-EOF &&
> +		This is a second file whose type will change.
> +		EOF

Micronit.  It would be nicer to the readers to make it clear that
there is no funny substitution to be worried about by quoting the
end marker of these here document, i.e.

		cat >dest <<-\EOF &&
                text without any funny substitution business
                EOF

> +		p4 add file1 file2 &&
> +		p4 submit -d "add files"
> +	)
> +'
> +
> +test_expect_success 'change file to symbolic link' '

This needs a SYMLINKS prerequisite so that it is skipped on systems
that lack support for symbolic links, i.e.

	test_expect_success SYMLINKS 'change file to symbolic link' '

The same for the next one.

Thanks.

next prev parent reply	other threads:[~2016-01-04 21:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 10:52 [PATCH v2] git-p4.py: add support for filetype change Romain Picard
2016-01-04 21:55 ` Junio C Hamano [this message]
2016-01-04 22:16 ` Luke Diamand
2016-01-05 13:08   ` Romain Picard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtwmtm2m3.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git-owner@vger$(echo .)kernel.org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=larsxschneider@gmail$(echo .)com \
    --cc=luke@diamand$(echo .)org \
    --cc=romain.picard@oakbits$(echo .)com \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox