From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>,
git@vger•kernel.org, rappazzo@gmail•com, kyle@kyleam•com,
sunshine@sunshineco•com
Subject: Re: [PATCH] setup: do not create $X/gitdir unnecessarily when accessing git file $X
Date: Mon, 02 Nov 2015 12:51:16 -0800 [thread overview]
Message-ID: <xmqqtwp4dt17.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20151102203507.GB10722@sigill.intra.peff.net> (Jeff King's message of "Mon, 2 Nov 2015 15:35:07 -0500")
Jeff King <peff@peff•net> writes:
> [2] I suspect this code should use write_file_gently(). What happens if
> I have a read-only linked checkout?
Or you may not be the owner of the repository, you think you are
doing a read-only operation, and you silently end up creating a file
that cannot be written by the repository owner?
Honestly, I think this whole "just in case the user moved without
telling us, we sneakily fix things without telling the user" should
just go away. This is not the first incidence of a tool trying to
be overly clever and pretend to know better than the end user biting
us, is it?
next prev parent reply other threads:[~2015-11-02 20:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 22:04 What's the ".git/gitdir" file? Kyle Meyer
2015-10-27 22:22 ` Stefan Beller
2015-10-27 22:42 ` Randall S. Becker
2015-10-27 22:54 ` Stefan Beller
2015-10-27 22:54 ` Junio C Hamano
2015-10-27 23:26 ` Mike Rappazzo
2015-10-28 16:23 ` Junio C Hamano
2015-11-02 19:08 ` [PATCH] setup: do not create $X/gitdir unnecessarily when accessing git file $X Nguyễn Thái Ngọc Duy
2015-11-02 20:01 ` Eric Sunshine
2015-11-02 20:35 ` Jeff King
2015-11-02 20:51 ` Junio C Hamano [this message]
2015-11-02 20:52 ` Jeff King
2015-11-03 5:48 ` Duy Nguyen
2015-11-03 19:54 ` Junio C Hamano
2015-12-27 3:43 ` [PATCH] worktree: stop supporting moving worktrees manually Nguyễn Thái Ngọc Duy
2015-12-28 6:22 ` Eric Sunshine
2015-12-29 13:55 ` Duy Nguyen
2015-12-31 5:59 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwp4dt17.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kyle@kyleam$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=rappazzo@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox