From: Junio C Hamano <gitster@pobox•com>
To: Ben Boeckel <mathstuf@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v5] remote: add get-url subcommand
Date: Wed, 16 Sep 2015 15:51:54 -0700 [thread overview]
Message-ID: <xmqqtwqukmet.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1442368427-3311-1-git-send-email-mathstuf@gmail.com> (Ben Boeckel's message of "Tue, 15 Sep 2015 21:53:47 -0400")
Ben Boeckel <mathstuf@gmail•com> writes:
> +get_url_test () {
> + cat >expect &&
> + test_expect_success "get-url $*" "
> + git remote get-url $* >actual &&
> + test_cmp expect actual
> + "
> +}
This makes any use of get_url_test inside test_expect_success wrong,
I suspect. Try running the tests under prove. I think it will
complain that the test numbers do not match or something.
Minimally, this would probably fix the breakage.
t/t5505-remote.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index f03ba4c..dfaf9d9 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -921,10 +921,8 @@ test_expect_success 'new remote' '
get_url_test () {
cat >expect &&
- test_expect_success "get-url $*" "
- git remote get-url $* >actual &&
- test_cmp expect actual
- "
+ git remote get-url "$@" >actual &&
+ test_cmp expect actual
}
test_expect_success 'get-url on new remote' '
next prev parent reply other threads:[~2015-09-16 22:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 17:38 [PATCH] add ls-remote --get-push-url option Ben Boeckel
2015-07-31 17:38 ` [PATCH] ls-remote: add " Ben Boeckel
2015-07-31 18:40 ` [PATCH] add ls-remote " Junio C Hamano
2015-07-31 18:56 ` Ben Boeckel
2015-07-31 19:02 ` Junio C Hamano
2015-07-31 19:04 ` Ben Boeckel
2015-07-31 19:16 ` Junio C Hamano
2015-07-31 20:51 ` Ben Boeckel
2015-08-03 21:00 ` [PATCH v2] add git-url subcommand Ben Boeckel
2015-08-03 21:00 ` [PATCH v2] remote: add get-url subcommand Ben Boeckel
2015-08-03 23:38 ` Eric Sunshine
2015-08-04 0:16 ` Ben Boeckel
2015-08-04 0:45 ` Eric Sunshine
2015-08-04 14:56 ` [PATCH v3] " Ben Boeckel
2015-08-05 20:34 ` Junio C Hamano
2015-08-05 21:33 ` Ben Boeckel
2015-08-05 21:39 ` Junio C Hamano
2015-09-04 14:30 ` [PATCH v4] " Ben Boeckel
2015-09-04 22:40 ` Junio C Hamano
2015-09-16 1:53 ` [PATCH v5] " Ben Boeckel
2015-09-16 22:51 ` Junio C Hamano [this message]
2015-09-17 0:19 ` [PATCH v6] " Ben Boeckel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwqukmet.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mathstuf@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox