From: Junio C Hamano <gitster@pobox•com>
To: Lawrence Siebert <lawrencesiebert@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/4] list-object: add get_commit_count function
Date: Fri, 03 Jul 2015 10:49:40 -0700 [thread overview]
Message-ID: <xmqqtwtl3zd7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1435815536-30611-1-git-send-email-lawrencesiebert@gmail.com> (Lawrence Siebert's message of "Wed, 1 Jul 2015 22:38:53 -0700")
Lawrence Siebert <lawrencesiebert@gmail•com> writes:
> Moving commit counting from rev-list into list-object which is a step
> toward letting git log do counting as well.
>
> Signed-off-by: Lawrence Siebert <lawrencesiebert@gmail•com>
> ---
No way. Look at the things provided by list-objects.c API. They
are not about formatting outputs. printf() calls do not belong
there.
next prev parent reply other threads:[~2015-07-03 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 5:38 [PATCH 1/4] list-object: add get_commit_count function Lawrence Siebert
2015-07-02 5:38 ` [PATCH 2/4] log: add --count option to git log Lawrence Siebert
2015-07-02 9:14 ` Remi Galan Alfonso
2015-07-02 23:45 ` Lawrence Siebert
2015-07-02 5:38 ` [PATCH 3/4] log --count: added test Lawrence Siebert
2015-07-02 9:09 ` Remi Galan Alfonso
2015-07-02 5:38 ` [PATCH 4/4] git-log: update man documentation for --count Lawrence Siebert
2015-07-02 9:13 ` [PATCH 1/4] list-object: add get_commit_count function Remi Galan Alfonso
2015-07-03 17:49 ` Junio C Hamano [this message]
2015-07-03 18:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwtl3zd7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=lawrencesiebert@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox