From: Junio C Hamano <gitster@pobox•com>
To: Ariel Faigon <github.2009@yendor•com>
Cc: git <git@vger•kernel.org>
Subject: Re: [PATCH] git-completion.tcsh: fix redirect with noclobber
Date: Tue, 09 Jun 2015 11:20:19 -0700 [thread overview]
Message-ID: <xmqqtwug7nh8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150609172515.GA20638@yendor.com> (Ariel Faigon's message of "Tue, 9 Jun 2015 10:25:15 -0700")
Ariel Faigon <github.2009@yendor•com> writes:
> tcsh users who happen to have 'set noclobber' elsewhere in their
> ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and
> the tcsh completion file doesn't get generated/updated.
>
> Adding a `!` in the redirect works correctly for both clobber (default)
> and 'set noclobber' users.
>
> Helped-by: Junio C Hamano <gitster@pobox•com>
> Reviewed-by: Christian Couder <christian.couder@gmail•com>
> Signed-off-by: Ariel Faigon <github.2009@yendor•com>
> ---
Thanks for enduring three iterations for a single-liner. This
versio will show nicely in "git log -p" output ;-)
In case anybody is wondering, that "Helped-by: notifications@github"
was merely because I said "this change makes sense, care to send it
over to us at git@vger?" from github UI on Ariel's commit. I do not
deserve helped-by for merely encouraging participation.
Will queue. Thanks again.
>
> contrib/completion/git-completion.tcsh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
> index 6104a42..4a790d8 100644
> --- a/contrib/completion/git-completion.tcsh
> +++ b/contrib/completion/git-completion.tcsh
> @@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
> exit
> endif
>
> -cat << EOF > ${__git_tcsh_completion_script}
> +cat << EOF >! ${__git_tcsh_completion_script}
> #!bash
> #
> # This script is GENERATED and will be overwritten automatically.
prev parent reply other threads:[~2015-06-09 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 17:25 [PATCH] git-completion.tcsh: fix redirect with noclobber Ariel Faigon
2015-06-09 18:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwug7nh8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=github.2009@yendor$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox