Subject: Re: [PATCH 3/4] diff --cc: relax too strict paths picking

From: Junio C Hamano <[email-masked]>
Date: Thu, 02 Apr 2015 13:59:48 -0700

Max Kirillov <[email-masked]> writes:

Again, just surface nitpicks.

[side: Kirill Smelkov <[email-masked]> removed from CC, as the
ddress just bounced for me]

> +static int changed_parents(struct combine_diff_path *p, int n)
> +{
> +	int parent_idx;
> +	int result = 0;
> +
> +	for (parent_idx = 0; parent_idx < n; ++parent_idx) {
> +		if (p->parent[parent_idx].status != ' ')
> +			++result;

We write C (not C++) and favor post_increment++ over ++pre_increment
when there is no valid reason to do otherwise (e.g. the result of
increment getting used in a larger expression).

Thanks.