From: Junio C Hamano <gitster@pobox•com>
To: Thomas Gummerer <t.gummerer@gmail•com>
Cc: git@vger•kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Subject: Re: [PATCH] t1700: make test pass with index-v4
Date: Fri, 20 Mar 2015 11:06:53 -0700 [thread overview]
Message-ID: <xmqqtwxfee6a.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150320173750.GA6545@hank> (Thomas Gummerer's message of "Fri, 20 Mar 2015 18:37:50 +0100")
Thomas Gummerer <t.gummerer@gmail•com> writes:
> On 03/20, Junio C Hamano wrote:
>> Thomas Gummerer <t.gummerer@gmail•com> writes:
>>
>> > The different index versions have different sha-1 checksums. Those
>> > checksums are checked in t1700, which makes it fail when run with index
>> > v4. Fix it.
>>
>> I am more interested to see how you managed to use index v4 in the
>> tests be described next to "when run with index v4". I thought we
>> were controling these things fairly tightly (e.g. we disable hooks,
>> move $HOME to avoid getting affected by your personal settings,
>> etc.).
>
> The tests can be run with index-v4 by setting TEST_GIT_INDEX_VERSION
> in config.mak. This configuration was introduced in 5d9fc88 test-lib:
> allow setting the index format version.
An updated patch to mention "when run with TEST_GIT_INDEX_VERSION=4"
in the log message was what I was asking for ;-)
next prev parent reply other threads:[~2015-03-20 18:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 15:09 [PATCH] t1700: make test pass with index-v4 Thomas Gummerer
2015-03-20 17:23 ` Junio C Hamano
2015-03-20 17:37 ` Thomas Gummerer
2015-03-20 18:06 ` Junio C Hamano [this message]
2015-03-20 18:20 ` [PATCH v2] " Thomas Gummerer
2015-03-20 19:38 ` Junio C Hamano
2015-03-20 19:59 ` Thomas Gummerer
2015-03-20 21:43 ` [PATCH 0/2] fix test suite with split index Thomas Gummerer
2015-03-20 21:43 ` [PATCH 1/2] test-lib: allow using split index in the test suite Thomas Gummerer
2015-03-20 21:55 ` Junio C Hamano
2015-03-20 22:12 ` Thomas Gummerer
2015-03-20 21:43 ` [PATCH 2/2] read-cache: fix reading of split index Thomas Gummerer
2015-03-24 13:02 ` Duy Nguyen
2015-03-24 17:00 ` [PATCH] read-cache: tighten checks for do_read_index Thomas Gummerer
2015-03-24 21:33 ` Junio C Hamano
2015-03-24 21:51 ` Thomas Gummerer
2015-03-24 17:07 ` [PATCH 2/2] read-cache: fix reading of split index Thomas Gummerer
2015-03-24 17:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwxfee6a.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=t.gummerer@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox