From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: John Szakmeister <john@szakmeister•net>, git@vger•kernel.org
Subject: Re: [PATCH v2] diff-highlight: exit when a pipe is broken
Date: Tue, 04 Nov 2014 12:52:57 -0800 [thread overview]
Message-ID: <xmqqtx2epu1i.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141104200932.GA15149@peff.net> (Jeff King's message of "Tue, 4 Nov 2014 15:09:32 -0500")
Jeff King <peff@peff•net> writes:
> On Tue, Nov 04, 2014 at 03:01:12PM -0500, John Szakmeister wrote:
>
>> While using diff-highlight with other tools, I have discovered that Python
>> ignores SIGPIPE by default. Unfortunately, this also means that tools
>> attempting to launch a pager under Python--and don't realize this is
>> happening--means that the subprocess inherits this setting. In this case, it
>> means diff-highlight will be launched with SIGPIPE being ignored. Let's work
>> with those broken scripts by restoring the default SIGPIPE handler.
>>
>> Signed-off-by: John Szakmeister <john@szakmeister•net>
>> ---
>> Incorporates feedback from Jeff King and now we just restore the default signal
>> handler using the correct case of 'DEFAULT'.
>
> Thanks, this version looks much simpler. :)
>
> Acked-by: Jeff King <peff@peff•net>
Thanks, both. The patch looks good. Will queue.
prev parent reply other threads:[~2014-11-04 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 20:01 [PATCH v2] diff-highlight: exit when a pipe is broken John Szakmeister
2014-11-04 20:09 ` Jeff King
2014-11-04 20:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx2epu1i.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=john@szakmeister$(echo .)net \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox