From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] gc --auto: do not run 'pack-refs' and 'reflog expire' twice
Date: Tue, 02 Sep 2014 12:16:22 -0700 [thread overview]
Message-ID: <xmqqtx4pzvcp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqzjeh28p0.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 02 Sep 2014 11:12:11 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Nguyễn Thái Ngọc Duy <pclouds@gmail•com> writes:
>
>> In the --auto code path, gc_before_repack() is called once in parent
>> process then again in the forked process. Stop the second run.
>
> Hmph. Is the true reason why this happens because we have two calls
> to gc_before_repack() in the main, and one is before daemonize()?
> Shouldn't this protection be in the caller?
Actually, I think the function already is protecting wastage of
getting called twice by saying "I've done pack-refs already" and
"I've done prune-reflogs already" by setting the two variables to
zero. Isn't that sufficient?
What problem is this patch trying to fix?
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail•com>
>> ---
>> builtin/gc.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/builtin/gc.c b/builtin/gc.c
>> index 8d219d8..fb0cff3 100644
>> --- a/builtin/gc.c
>> +++ b/builtin/gc.c
>> @@ -261,6 +261,11 @@ static const char *lock_repo_for_gc(int force, pid_t* ret_pid)
>>
>> static int gc_before_repack(void)
>> {
>> + static int nr_runs;
>> +
>> + if (nr_runs++)
>> + return 0;
>> +
>> if (pack_refs && run_command_v_opt(pack_refs_cmd.argv, RUN_GIT_CMD))
>> return error(FAILED_RUN, pack_refs_cmd.argv[0]);
next prev parent reply other threads:[~2014-09-02 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 4:33 [PATCH] gc --auto: do not run 'pack-refs' and 'reflog expire' twice Nguyễn Thái Ngọc Duy
2014-09-02 18:12 ` Junio C Hamano
2014-09-02 19:16 ` Junio C Hamano [this message]
2014-09-04 14:13 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx4pzvcp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox