From: Junio C Hamano <gitster@pobox•com>
To: Stepan Kasal <kasal@ucw•cz>
Cc: Karsten Blees <karsten.blees@gmail•com>,
Johannes Sixt <j6t@kdbg•org>,
GIT Mailing-list <git@vger•kernel.org>,
msysGit <msysgit@googlegroups•com>,
Pat Thoyts <patthoyts@users•sourceforge.net>
Subject: Re: [PATCH 5/6] t9902: mingw-specific fix for gitfile link files
Date: Thu, 17 Jul 2014 13:42:28 -0700 [thread overview]
Message-ID: <xmqqtx6fogy3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1405611425-10009-6-git-send-email-kasal@ucw.cz> (Stepan Kasal's message of "Thu, 17 Jul 2014 17:37:04 +0200")
Stepan Kasal <kasal@ucw•cz> writes:
> From: Pat Thoyts <patthoyts@users•sourceforge.net>
>
> The path in a .git platform independent link file needs to be absolute
> and under mingw we need it to be a windows type path, not a unix style
> path so it should start with a drive letter and not a /.
OK. We seem to have uses of "pwd -P" in other tests; don't they
need a similar treatment, and if not why not?
>
> Signed-off-by: Pat Thoyts <patthoyts@users•sourceforge.net>
> Signed-off-by: Stepan Kasal <kasal@ucw•cz>
> ---
> t/t9902-completion.sh | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
> index 1d1c106..f10a752 100755
> --- a/t/t9902-completion.sh
> +++ b/t/t9902-completion.sh
> @@ -212,9 +212,18 @@ test_expect_success '__gitdir - non-existing $GIT_DIR' '
> )
> '
>
> +function pwd_P_W () {
> + if test_have_prereq MINGW
> + then
> + pwd -W
> + else
> + pwd -P
> + fi
> +}
> +
> test_expect_success '__gitdir - gitfile in cwd' '
> - echo "$(pwd -P)/otherrepo/.git" >expected &&
> - echo "gitdir: $TRASH_DIRECTORY/otherrepo/.git" >subdir/.git &&
> + echo "$(pwd_P_W)/otherrepo/.git" >expected &&
> + echo "gitdir: $(pwd_P_W)/otherrepo/.git" >subdir/.git &&
> test_when_finished "rm -f subdir/.git" &&
> (
> cd subdir &&
> @@ -224,8 +233,8 @@ test_expect_success '__gitdir - gitfile in cwd' '
> '
>
> test_expect_success '__gitdir - gitfile in parent' '
> - echo "$(pwd -P)/otherrepo/.git" >expected &&
> - echo "gitdir: $TRASH_DIRECTORY/otherrepo/.git" >subdir/.git &&
> + echo "$(pwd_P_W)/otherrepo/.git" >expected &&
> + echo "gitdir: $(pwd_P_W)/otherrepo/.git" >subdir/.git &&
> test_when_finished "rm -f subdir/.git" &&
> (
> cd subdir/subsubdir &&
> --
> 2.0.0.9635.g0be03cb
>
> --
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups•com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups•com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups•com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-07-17 20:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 20:05 Topic sk/mingw-unicode-spawn-args breaks tests Johannes Sixt
2014-07-11 19:49 ` Karsten Blees
2014-07-12 7:50 ` Stepan Kasal
2014-07-15 0:21 ` Johannes Schindelin
2014-07-15 13:43 ` [PATCH 0/3] fix test suite with mingw-unicode patches Stepan Kasal
2014-07-15 13:43 ` [PATCH 1/3] Win32: Unicode file name support (except dirent) Stepan Kasal
2014-07-15 13:43 ` [PATCH 2/3] Win32: Unicode file name support (dirent) Stepan Kasal
2014-07-15 13:43 ` [PATCH 3/3] tests: do not pass iso8859-1 encoded parameter Stepan Kasal
2014-07-15 13:53 ` [PATCH 0/3] fix test suite with mingw-unicode patches Stepan Kasal
2014-07-15 18:20 ` Junio C Hamano
2014-07-15 22:52 ` Karsten Blees
2014-07-15 22:53 ` [PATCH 1/2] MinGW: fix compile error due to missing ELOOP Karsten Blees
2014-07-15 23:42 ` Jonathan Nieder
2014-07-15 23:57 ` Karsten Blees
2014-07-16 17:43 ` Junio C Hamano
2014-07-15 22:54 ` [PATCH 2/2] config: use chmod() instead of fchmod() Karsten Blees
2014-07-16 5:33 ` Johannes Sixt
2014-07-16 10:53 ` Karsten Blees
2014-07-16 22:16 ` Junio C Hamano
2014-07-17 8:57 ` Karsten Blees
2014-07-16 9:29 ` [PATCH 0/3] fix test suite with mingw-unicode patches Stepan Kasal
2014-07-16 11:01 ` Thomas Braun
2014-07-17 15:36 ` [PATCH 0/6] mingw test fixes Stepan Kasal
2014-07-17 15:37 ` [PATCH 1/6] MinGW: Skip test redirecting to fd 4 Stepan Kasal
2014-07-17 18:41 ` Junio C Hamano
2014-07-17 20:06 ` Johannes Schindelin
2014-07-17 20:18 ` Karsten Blees
2014-07-17 20:38 ` Junio C Hamano
2014-07-17 15:37 ` [PATCH 2/6] Disable t0110's high-bit test on Windows Stepan Kasal
2014-07-17 18:20 ` Karsten Blees
2014-07-18 18:26 ` Junio C Hamano
2014-07-19 19:37 ` [PATCH] t0110/MinGW: skip tests that pass arbitrary bytes on the command line Karsten Blees
2014-07-21 16:41 ` Junio C Hamano
2014-07-17 15:37 ` [PATCH 3/6] MinGW: disable legacy encoding tests Stepan Kasal
2014-07-17 15:37 ` [PATCH 4/6] t4210: skip command-line encoding tests on mingw Stepan Kasal
2014-07-18 9:52 ` Erik Faye-Lund
2014-07-21 16:59 ` Junio C Hamano
2014-07-21 17:45 ` Johannes Schindelin
2014-07-21 19:21 ` Johannes Sixt
2014-07-21 20:07 ` Junio C Hamano
2014-07-21 22:29 ` Junio C Hamano
2014-07-21 22:39 ` Junio C Hamano
2014-07-21 22:30 ` [PATCH 2/2] test prerequisites: enumerate with commas Junio C Hamano
2014-07-17 15:37 ` [PATCH 5/6] t9902: mingw-specific fix for gitfile link files Stepan Kasal
2014-07-17 20:42 ` Junio C Hamano [this message]
2014-07-17 15:37 ` [PATCH 6/6] t800[12]: work around MSys limitation Stepan Kasal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx6fogy3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=karsten.blees@gmail$(echo .)com \
--cc=kasal@ucw$(echo .)cz \
--cc=msysgit@googlegroups$(echo .)com \
--cc=patthoyts@users$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox