From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Elia Pinto <gitter.spiros@gmail•com>,
git@vger•kernel.org, tboegi@web•de, dak@gnu•org
Subject: Re: [PATCH v2] Get rid of the non portable shell export VAR=VALUE costruct
Date: Fri, 23 May 2014 14:56:26 -0700 [thread overview]
Message-ID: <xmqqtx8ggnw5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140523184405.GE12314@google.com> (Jonathan Nieder's message of "Fri, 23 May 2014 11:44:05 -0700")
Jonathan Nieder <jrnieder@gmail•com> writes:
> - /^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not por...
> + /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is n...
I see you also tightened what the "variable" to be assigned should
look like, which is a good change to avoid false positives.
Because the inter-word dash is taken as a word "\b"oundary, that
change incidentally prevents a false positive from triggering on
something like:
git fast-export --option=value
;-)
next prev parent reply other threads:[~2014-05-23 21:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 10:15 [PATCH v2] Get rid of the non portable shell export VAR=VALUE costruct Elia Pinto
2014-05-23 16:18 ` Jonathan Nieder
2014-05-23 18:18 ` Junio C Hamano
2014-05-23 18:39 ` Junio C Hamano
2014-05-23 18:48 ` Jonathan Nieder
2014-05-23 18:44 ` Jonathan Nieder
2014-05-23 20:40 ` Torsten Bögershausen
2014-05-23 21:25 ` Junio C Hamano
2014-05-23 21:56 ` Junio C Hamano [this message]
2014-05-23 20:38 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx8ggnw5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitter.spiros@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox