From: Junio C Hamano <gitster@pobox•com>
To: "brian m. carlson" <sandals@crustytoothpaste•net>
Cc: git@vger•kernel.org, Nicolas Vigier <boklm@mars-attacks•org>
Subject: Re: [PATCH v2 2/9] git-sh-setup.sh: add variable to use the stuck-long mode
Date: Mon, 27 Jan 2014 15:21:05 -0800 [thread overview]
Message-ID: <xmqqtxcpm2ou.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1390524666-51274-3-git-send-email-sandals@crustytoothpaste.net> (brian m. carlson's message of "Fri, 24 Jan 2014 00:50:59 +0000")
"brian m. carlson" <sandals@crustytoothpaste•net> writes:
> From: Nicolas Vigier <boklm@mars-attacks•org>
>
> If the variable $OPTIONS_STUCKLONG is not empty, then rev-parse
> option parsing is done in --stuck-long mode.
>
> Signed-off-by: Nicolas Vigier <boklm@mars-attacks•org>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste•net>
> ---
> contrib/examples/git-checkout.sh | 1 +
> contrib/examples/git-clean.sh | 1 +
> contrib/examples/git-clone.sh | 1 +
> contrib/examples/git-merge.sh | 1 +
> contrib/examples/git-repack.sh | 1 +
Hmmm, especially given that nobody is exercising the ``updated''
code even in our testsuite, is it a good idea to touch these?
The STUCKLONG never existed back when they were scripted. It just
adds noise when trying to view them for hints, no?
> diff --git a/git-sh-setup.sh b/git-sh-setup.sh
> index fffa3c7..5f28b32 100644
> --- a/git-sh-setup.sh
> +++ b/git-sh-setup.sh
> @@ -72,6 +72,8 @@ if test -n "$OPTIONS_SPEC"; then
> parseopt_extra=
> [ -n "$OPTIONS_KEEPDASHDASH" ] &&
> parseopt_extra="--keep-dashdash"
> + [ -n "$OPTIONS_STUCKLONG" ] &&
> + parseopt_extra="$parseopt_extra --stuck-long"
>
> eval "$(
> echo "$OPTIONS_SPEC" |
next prev parent reply other threads:[~2014-01-27 23:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 0:50 [PATCH v2 0/9] add --gpg-sign to rebase and pull brian m. carlson
2014-01-24 0:50 ` [PATCH v2 1/9] cherry-pick, revert: add the --gpg-sign option brian m. carlson
2014-01-24 21:00 ` Junio C Hamano
2014-01-24 21:08 ` brian m. carlson
2014-01-24 22:45 ` Junio C Hamano
2014-01-24 0:50 ` [PATCH v2 2/9] git-sh-setup.sh: add variable to use the stuck-long mode brian m. carlson
2014-01-27 23:21 ` Junio C Hamano [this message]
2014-01-24 0:51 ` [PATCH v2 3/9] am: parse options in " brian m. carlson
2014-01-24 0:51 ` [PATCH v2 4/9] am: add the --gpg-sign option brian m. carlson
2014-01-27 23:26 ` Junio C Hamano
2014-01-24 0:51 ` [PATCH v2 5/9] rebase: remove useless arguments check brian m. carlson
2014-01-24 0:51 ` [PATCH v2 6/9] rebase: don't try to match -M option brian m. carlson
2014-01-24 0:51 ` [PATCH v2 7/9] rebase: parse options in stuck-long mode brian m. carlson
2014-01-24 0:51 ` [PATCH v2 8/9] rebase: add the --gpg-sign option brian m. carlson
2014-01-27 23:36 ` Junio C Hamano
2014-01-27 23:59 ` brian m. carlson
2014-01-24 0:51 ` [PATCH v2 9/9] pull: " brian m. carlson
2014-01-27 23:31 ` Junio C Hamano
2014-02-01 1:01 ` brian m. carlson
2014-02-03 18:04 ` Junio C Hamano
2014-01-24 9:14 ` [PATCH v2 0/9] add --gpg-sign to rebase and pull Nicolas Vigier
2014-01-24 20:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtxcpm2ou.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=boklm@mars-attacks$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox