From: Junio C Hamano <gitster@pobox•com>
To: Steven Rostedt <rostedt@goodmis•org>
Cc: Paul Gortmaker <paul.gortmaker@windriver•com>,
<git@vger•kernel.org>,
Linus Torvalds <torvalds@linux-foundation•org>
Subject: Re: Should "git apply --check" imply verbose?
Date: Tue, 20 Aug 2013 14:43:56 -0700 [thread overview]
Message-ID: <xmqqtxikujfn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130820155433.217abb3e@gandalf.local.home> (Steven Rostedt's message of "Tue, 20 Aug 2013 15:54:33 -0400")
Steven Rostedt <rostedt@goodmis•org> writes:
>> > Linus told me that "git apply" was basically a replacement for patch.
>> > Why would you think it would not be a good idea to assume that people
>> > would not be familiar with how GNU patch works?
>>
>> The audience of Git these days are far more widely spread than the
>> kernel circle. I am not opposed to _helping_ those who happen to
>> know "patch", but I was against a description that assumes readers
>> know it, i.e. making it a requirement to know "patch" to understand
>> "apply".
>
> Patch is used by much more than just the kernel folks ;-) I've been
> using patch much longer than I've been doing kernel development.
Yeah, I was familiar with "patch" when I started Git, too ;-).
But only folks in the kernel circle will be told by Linus the
similarity between apply and patch, no?
In any case...
>> In other words, your enhancement to the documentation could go like:
>>
>> ... By default, ... With this option, you will additionally
>> see such and such and such in the output (this is similar to
>> what "patch --dry-run" would give you). See the EXAMPLES
>> section to get a feel of how it looks like.
>>
>> and I would not be opposed, as long as "such and such and such" are
>> written in such a way that the reader does not have to have a prior
>> experience with GNU patch in order to understand it.
... I forgot to also add: And by mentioning "similar to", people who
are familiar with "patch" are also helped by their pre-existing
knowledge, so both kinds of people win.
Thanks.
next prev parent reply other threads:[~2013-08-20 21:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 15:11 Should "git apply --check" imply verbose? Paul Gortmaker
2013-08-20 17:57 ` Junio C Hamano
2013-08-20 18:45 ` Paul Gortmaker
2013-08-20 18:51 ` Jonathan Nieder
2013-08-20 18:59 ` Paul Gortmaker
2013-08-20 19:07 ` Junio C Hamano
2013-08-20 19:15 ` Steven Rostedt
2013-08-20 19:45 ` Junio C Hamano
2013-08-20 19:54 ` Steven Rostedt
2013-08-20 20:19 ` Paul Gortmaker
2013-08-20 21:44 ` Junio C Hamano
2013-08-20 21:43 ` Junio C Hamano [this message]
2013-08-20 22:37 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtxikujfn.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox