From: Junio C Hamano <gitster@pobox•com>
To: "Heath Dutton🕴️ via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, jrnieder@gmail•com,
"Heath Dutton🕴️" <heathdutton@gmail•com>
Subject: Re: [PATCH] doc: define timestamp in pack protocol grammar
Date: Sun, 04 Jan 2026 15:28:29 +0900 [thread overview]
Message-ID: <xmqqv7hhnb76.fsf@gitster.g> (raw)
In-Reply-To: <pull.2154.git.git.1767496120852.gitgitgadget@gmail.com> (Heath Dutton's message of "Sun, 04 Jan 2026 03:08:40 +0000")
"Heath Dutton🕴️ via GitGitGadget" <gitgitgadget@gmail•com> writes:
> From: =?UTF-8?q?Heath=20Dutton=F0=9F=95=B4=EF=B8=8F?=
> <heathdutton@gmail•com>
This name is expected to be identical to ...
> The grammar for depth-request uses 'timestamp' but never defines it,
> unlike 'depth' which is properly defined as '1*DIGIT'. Add the missing
> definition.
>
> Signed-off-by: Heath Dutton <heathdutton@gmail•com>
... what we have here. There is something weird going on after the
name before the e-mail on the in-body From: line, though?
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2154%2Fheathdutton%2Fhd%2Fdoc-protocol-timestamp-40000018-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2154/heathdutton/hd/doc-protocol-timestamp-40000018-v1
> Pull-Request: https://github.com/git/git/pull/2154
>
> Documentation/gitprotocol-pack.adoc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/gitprotocol-pack.adoc b/Documentation/gitprotocol-pack.adoc
> index 837b691c89..7ad63322c2 100644
> --- a/Documentation/gitprotocol-pack.adoc
> +++ b/Documentation/gitprotocol-pack.adoc
> @@ -273,6 +273,7 @@ out of what the server said it could do with the first 'want' line.
> additional-want = PKT-LINE("want" SP obj-id)
>
> depth = 1*DIGIT
> + timestamp = 1*DIGIT
OK.
It was added at 569e554b (upload-pack: add deepen-since to cut
shallow repos based on time, 2016-06-12) by Duy for deepen-since
which is parsed using parse_timestamp() that is a fancier name for
strtoumax(), so 1*DIGIT sounds fine.
Thanks.
prev parent reply other threads:[~2026-01-04 6:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 3:08 [PATCH] doc: define timestamp in pack protocol grammar Heath Dutton🕴️ via GitGitGadget
2026-01-04 6:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7hhnb76.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=heathdutton@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox