Subject: Re: [PATCH v4 4/7] parse-options: rename `OPT_MAGNITUDE()` to `OPT_UNSIGNED()`

From: Junio C Hamano <[email-masked]>
Date: Thu, 17 Apr 2025 08:17:18 -0700

Patrick Steinhardt <[email-masked]> writes:

> With the preceding commit, `OPT_INTEGER()` has learned to support unit
> factors. Consequently, the major differencen between `OPT_INTEGER()` and
> `OPT_MAGNITUDE()` isn't the support of unit factors anymore, as both of
> them do support them now. Instead, the difference is that one handles
> signed and the other handles unsigned integers.
>
> Adapt the name of `OPT_MAGNITUDE()` accordingly by renaming it to
> `OPT_UNSIGNED()`.

Very good move.  It would have been very confusing if a new
developer had to choose between INTEGER and MAGNITUDE, and this
change nicely removes that "Huh?" factor.

Thanks.