From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org, Taylor Blau <me@ttaylorr•com>
Subject: Re: [PATCH 01/10] loose_object_info(): BUG() on inflating content with unknown type
Date: Tue, 25 Feb 2025 17:47:56 -0800 [thread overview]
Message-ID: <xmqqv7sxh3xv.fsf@gitster.g> (raw)
In-Reply-To: <20250225062824.GA1293961@coredump.intra.peff.net> (Jeff King's message of "Tue, 25 Feb 2025 01:28:24 -0500")
Jeff King <peff@peff•net> writes:
> It really makes me wonder if this "unknown type" stuff has any value
> at all. You can create an object with any type using "hash-object
> --literally -t". And you can ask about its type and size. But you can
> never retrieve the object content! Nor can you pack it or transfer it,
> since packs use a numeric type field.
Correct. IIRC, the "--literally" support was mostly for debugging,
and as you noticed, is very much limited because it can only create
funny objects that are loose. And the debugging was not really about
adding more object types, but was more about "what would our code do
when we see an object that is corrupt whose type we do not recognise".
I personally think the "--literally" should not survive the Git 3.0
boundary.
Thanks.
next prev parent reply other threads:[~2025-02-26 1:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 6:25 [PATCH 0/10] some zlib inflating bug fixes Jeff King
2025-02-25 6:28 ` [PATCH 01/10] loose_object_info(): BUG() on inflating content with unknown type Jeff King
2025-02-25 11:42 ` Patrick Steinhardt
2025-02-26 1:47 ` Junio C Hamano [this message]
2025-02-28 0:16 ` Taylor Blau
2025-03-04 6:43 ` Jeff King
2025-03-04 15:41 ` Junio C Hamano
2025-02-28 0:14 ` Taylor Blau
2025-02-25 6:29 ` [PATCH 02/10] unpack_loose_header(): simplify next_out assignment Jeff King
2025-02-28 0:18 ` Taylor Blau
2025-02-25 6:29 ` [PATCH 03/10] unpack_loose_header(): report headers without NUL as "bad" Jeff King
2025-02-25 6:29 ` [PATCH 04/10] unpack_loose_header(): fix infinite loop on broken zlib input Jeff King
2025-02-25 11:42 ` Patrick Steinhardt
2025-02-25 19:00 ` Eric Sunshine
2025-02-26 12:56 ` Junio C Hamano
2025-02-28 0:21 ` Taylor Blau
2025-02-25 6:30 ` [PATCH 05/10] git_inflate(): skip zlib_post_call() sanity check on Z_NEED_DICT Jeff King
2025-02-26 13:26 ` Junio C Hamano
2025-02-28 0:31 ` Taylor Blau
2025-03-04 7:08 ` Jeff King
2025-02-25 6:30 ` [PATCH 06/10] unpack_loose_header(): avoid numeric comparison of zlib status Jeff King
2025-02-28 0:32 ` Taylor Blau
2025-03-04 6:55 ` Jeff King
2025-02-25 6:31 ` [PATCH 07/10] unpack_loose_rest(): " Jeff King
2025-02-25 6:33 ` [PATCH 08/10] unpack_loose_rest(): never clean up zstream Jeff King
2025-02-26 13:16 ` Junio C Hamano
2025-02-25 6:33 ` [PATCH 09/10] unpack_loose_rest(): simplify error handling Jeff King
2025-02-26 13:46 ` Junio C Hamano
2025-02-28 0:34 ` Taylor Blau
2025-02-25 6:34 ` [PATCH 10/10] unpack_loose_rest(): rewrite return handling for clarity Jeff King
2025-02-28 0:36 ` Taylor Blau
2025-03-04 7:10 ` Jeff King
2025-03-04 21:32 ` Taylor Blau
2025-02-28 0:38 ` [PATCH 0/10] some zlib inflating bug fixes Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7sxh3xv.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=me@ttaylorr$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox