From: Junio C Hamano <gitster@pobox•com>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: Chandra Pratap <chandrapratap3519@gmail•com>,
git@vger•kernel.org, Patrick Steinhardt <ps@pks•im>,
Christian Couder <chriscool@tuxfamily•org>
Subject: Re: [GSoC][PATCH v4 0/11] t: port reftable/record_test.c to the unit testing framework framework
Date: Tue, 02 Jul 2024 08:14:31 -0700 [thread overview]
Message-ID: <xmqqv81nsu5k.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZT_x1Kf7EopU+RbBFzX3EPU5NWx6f8L9Uw=sM0MbCXDAQ@mail.gmail.com> (Karthik Nayak's message of "Tue, 2 Jul 2024 06:55:56 -0400")
Karthik Nayak <karthik.188@gmail•com> writes:
> Hello,
>
> Chandra Pratap <chandrapratap3519@gmail•com> writes:
>
>> In the recent codebase update (commit 8bf6fbd, 2023-12-09), a new unit
>> testing framework written entirely in C was introduced to the Git project
>> aimed at simplifying testing and reducing test run times.
>> Currently, tests for the reftable refs-backend are performed by a custom
>> testing framework defined by reftable/test_framework.{c, h}. Port
>> reftable/record_test.c to the unit testing framework and improve upon
>> the ported test.
>>
>> The first patch in the series moves the test to the unit testing framework,
>> and the rest of the patches improve upon the ported test.
>>
>> Mentored-by: Patrick Steinhardt <ps@pks•im>
>> Mentored-by: Christian Couder <chriscool@tuxfamily•org>
>> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail•com>
>>
>> ---
>> Changes in v4:
>> - Rename the tests to follow a 't_foo()' pattern instead
>> of 'test_foo()'
>> - Use hard-coded test input in the 10th and 11th patch
>>
>
> Nice, I see my comments from the previous versions are addressed. It
> looks good to me now!
Thanks, both.
prev parent reply other threads:[~2024-07-02 15:14 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 5:46 [GSoC][PATCH 0/11] t: port reftable/record_test.c to the unit testing framework Chandra Pratap
2024-06-21 5:47 ` [PATCH 01/11] t: move " Chandra Pratap
2024-06-21 5:47 ` [PATCH 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-06-21 5:47 ` [PATCH 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-06-21 5:47 ` [PATCH 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-06-21 5:47 ` [PATCH 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-06-21 5:47 ` [PATCH 06/11] t-reftable-record: add reftable_record_is_deletion() test for ref records Chandra Pratap
2024-06-21 5:47 ` [PATCH 07/11] t-reftable-record: add reftable_record_is_deletion() test for log records Chandra Pratap
2024-06-21 5:47 ` [PATCH 08/11] t-reftable-record: add reftable_record_is_deletion() test for obj records Chandra Pratap
2024-06-21 5:47 ` [PATCH 09/11] t-reftable-record: add reftable_record_is_deletion() test for index records Chandra Pratap
2024-06-21 5:47 ` [PATCH 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-06-21 5:47 ` [PATCH 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-06-21 6:09 ` [GSoC][PATCH 0/11] t: port reftable/record_test.c to the unit testing framework Chandra Pratap
2024-06-21 11:50 ` Chandra Pratap
2024-06-21 11:50 ` [PATCH 01/11] t: move " Chandra Pratap
2024-06-25 8:26 ` Karthik Nayak
2024-06-25 13:12 ` Chandra Pratap
2024-06-26 11:52 ` Karthik Nayak
2024-06-26 12:57 ` Chandra Pratap
2024-06-26 14:24 ` Han-Wen Nienhuys
2024-06-21 11:50 ` [PATCH 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-06-25 8:36 ` Karthik Nayak
2024-06-21 11:50 ` [PATCH 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-06-21 11:50 ` [PATCH 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-06-21 11:51 ` [PATCH 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-06-21 11:51 ` [PATCH 06/11] t-reftable-record: add ref tests for reftable_record_is_deletion() Chandra Pratap
2024-06-25 9:14 ` Karthik Nayak
2024-06-25 17:31 ` Eric Sunshine
2024-06-26 11:35 ` Karthik Nayak
2024-06-21 11:51 ` [PATCH 07/11] t-reftable-record: add log " Chandra Pratap
2024-06-21 11:51 ` [PATCH 08/11] t-reftable-record: add obj " Chandra Pratap
2024-06-21 11:51 ` [PATCH 09/11] t-reftable-record: add index " Chandra Pratap
2024-06-25 9:19 ` Karthik Nayak
2024-06-25 14:11 ` Chandra Pratap
2024-06-26 11:59 ` Karthik Nayak
2024-06-21 11:51 ` [PATCH 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-06-25 9:26 ` Karthik Nayak
2024-06-25 13:45 ` Chandra Pratap
2024-06-21 11:51 ` [PATCH 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-06-25 9:26 ` Karthik Nayak
2024-06-25 9:32 ` [GSoC][PATCH 0/11] t: port reftable/record_test.c to the unit testing framework Karthik Nayak
2024-06-28 6:19 ` [GSoC][PATCH v3 " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 01/11] t: move " Chandra Pratap
2024-06-30 16:24 ` Karthik Nayak
2024-06-28 6:19 ` [PATCH v3 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 06/11] t-reftable-record: add ref tests for reftable_record_is_deletion() Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 07/11] t-reftable-record: add log " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 08/11] t-reftable-record: add obj " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 09/11] t-reftable-record: add index " Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-06-30 18:59 ` Karthik Nayak
2024-07-01 7:26 ` Chandra Pratap
2024-07-01 9:51 ` Karthik Nayak
2024-07-01 13:17 ` Chandra Pratap
2024-06-28 6:19 ` [PATCH v3 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-06-30 19:11 ` Karthik Nayak
2024-06-30 19:12 ` [GSoC][PATCH v3 0/11] t: port reftable/record_test.c to the unit testing framework Karthik Nayak
2024-07-02 7:22 ` [GSoC][PATCH v4 0/11] t: port reftable/record_test.c to the unit testing framework framework Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 01/11] t: move reftable/record_test.c to the unit testing framework Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 02/11] t-reftable-record: add reftable_record_cmp() tests for log records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 03/11] t-reftable-record: add comparison tests for ref records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 04/11] t-reftable-record: add comparison tests for index records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 05/11] t-reftable-record: add comparison tests for obj records Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 06/11] t-reftable-record: add ref tests for reftable_record_is_deletion() Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 07/11] t-reftable-record: add log " Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 08/11] t-reftable-record: add obj " Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 09/11] t-reftable-record: add index " Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 10/11] t-reftable-record: add tests for reftable_ref_record_compare_name() Chandra Pratap
2024-07-02 7:22 ` [PATCH v4 11/11] t-reftable-record: add tests for reftable_log_record_compare_key() Chandra Pratap
2024-07-02 10:55 ` [GSoC][PATCH v4 0/11] t: port reftable/record_test.c to the unit testing framework framework Karthik Nayak
2024-07-02 15:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv81nsu5k.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=chandrapratap3519@gmail$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox