From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [PATCH] t5500: fix mistaken $SERVER reference in helper function
Date: Thu, 20 Jun 2024 11:06:43 -0700 [thread overview]
Message-ID: <xmqqv823v68c.fsf@gitster.g> (raw)
In-Reply-To: <ZnM3I11IRporu4sj@google.com> (Jonathan Nieder's message of "Thu, 20 Jun 2024 11:27:58 +0200")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Alas, in a copy-and-paste gone wrong, 07ef3c6604 gets the name of the
> blob (but not the commit) from "server" instead of $SERVER. And this
> happens to work because the first time we call this helper, $SERVER is
> "server". The only reason this happens to work at all is that we're
> looking at a blob id; if we looked at the commit id, then the
> timestamps wouldn't have matched.
>
> Thanks, the fix is obviously correct.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail•com>
>
> Particularly telling that the author of 07ef3c6604 introduced this
> typo while trying to make the tests _more_ robust.
;-)
Thanks both.
prev parent reply other threads:[~2024-06-20 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 12:52 [PATCH] t5500: fix mistaken $SERVER reference in helper function Jeff King
2024-06-20 9:27 ` Jonathan Nieder
2024-06-20 15:22 ` Jeff King
2024-06-20 18:06 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv823v68c.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox