Subject: Re: [PATCH 09/11] pack-objects: refer to delta objects by index instead of pointer

From: Junio C Hamano <[email-masked]>
Date: Thu, 01 Mar 2018 10:08:03 -0800

Nguyễn Thái Ngọc Duy  <[email-masked]> writes:

> Notice that packing_data::nr_objects is uint32_t, we could only handle
> maximum 4G objects and can address all of them with an uint32_t. If we
> use a pointer here, we waste 4 bytes on 64 bit architecture.
>
> Convert these delta pointers to indexes. Since we need to handle NULL
> pointers as well, the index is shifted by one [1].

Makes perfect sense.

I do not think losing 1 slot out of possible 4G is a regression,
unlike the 256 packfile limit 07/11 imposes.