From: Junio C Hamano <gitster@pobox•com>
To: Mike Hommey <mh@glandium•org>
Cc: "Torsten Bögershausen" <tboegi@web•de>, git@vger•kernel.org
Subject: Re: What's cooking in git.git (Jun 2016, #01; Thu, 2)
Date: Fri, 03 Jun 2016 16:47:33 -0700 [thread overview]
Message-ID: <xmqqvb1pzvfu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160603232653.GA24538@glandium.org> (Mike Hommey's message of "Sat, 4 Jun 2016 08:26:53 +0900")
Mike Hommey <mh@glandium•org> writes:
> In fact, the parser doesn't even reject the one that is considered
> invalid (the first).
My question was what the desired behaviour is, and if your "fix"
gives us that desired outcome.
> (Also, the discussion back then was about
> git://[example.com:123]:/path/to/repo, not
> git://[example.com:123]/path/to/repo)
I thought these two ought to be equivalent:
<scheme>://<host>:/<localpart>
<scheme>://<host>/<localpart>
so the distinction shouldn't matter, no?
The former's last colon is "I wanted to write a custom port, but
didn't spell it out, which is equivalent to spelling out the default
port, which in turn is equivalent to not having that :<port> at all.
next prev parent reply other threads:[~2016-06-03 23:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 22:52 What's cooking in git.git (Jun 2016, #01; Thu, 2) Junio C Hamano
2016-06-02 23:13 ` Mike Hommey
2016-06-03 5:07 ` Torsten Bögershausen
2016-06-03 15:59 ` Junio C Hamano
2016-06-03 23:26 ` Mike Hommey
2016-06-03 23:47 ` Junio C Hamano [this message]
2016-06-04 5:14 ` Mike Hommey
2016-06-04 14:51 ` Torsten Bögershausen
2016-06-04 21:46 ` Mike Hommey
2016-06-04 16:24 ` Junio C Hamano
2016-06-05 9:29 ` Torsten Bögershausen
2016-06-05 11:09 ` [PATCH v1 1/1] connect: [host:port] is lagacy for ssh tboegi
2016-06-05 18:56 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvb1pzvfu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mh@glandium$(echo .)org \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox