Subject: Re: [PATCH v8 10/10] ce_compare_data() did not respect conversion

From: Junio C Hamano <[email-masked]>
Date: Fri, 29 Apr 2016 14:09:12 -0700

[email-masked] writes:

> From: Torsten Bögershausen <[email-masked]>
>
> We define the working tree file is clean if either:
>
>   * the result of running convert_to_git() on the working tree
>     contents matches what is in the index (because that would mean
>     doing another "git add" on the path is a no-op); OR
>
>   * the result of running convert_to_working_tree() on the content
>     in the index matches what is in the working tree (because that
>     would mean doing another "git checkout -f" on the path is a
>     no-op).
>
> Add an extra check in ce_compare_data() in read_cache.c.
>
> Helped-by: Junio C Hamano <[email-masked]>

Well, didn't I do exactly the above much earlier and discarded it
because that breaks the definition of "diff"?  Or is this doing
something differently?