From: Junio C Hamano <gitster@pobox•com>
To: Max Horn <max@quendi•de>
Cc: "git\@vger.kernel.org list" <git@vger•kernel.org>
Subject: Re: [ANNOUNCE] Git v2.8.0-rc2
Date: Mon, 14 Mar 2016 11:10:52 -0700 [thread overview]
Message-ID: <xmqqvb4p9bgz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <006DA180-E4B6-404E-9377-F2BB41F65591@quendi.de> (Max Horn's message of "Sat, 12 Mar 2016 10:11:15 +0100")
Max Horn <max@quendi•de> writes:
>> On 11 Mar 2016, at 00:04, Junio C Hamano <gitster@pobox•com> wrote:
>> ...
>> * "branch --delete" has "branch -d" but "push --delete" does not.
>
> This states a problem, but not whether (and how) it was resolved?
Thanks; how about
* "push" learned that its "--delete" option can be shortened to
"-d", just like "branch --delete" and "branch -d" are the same
thing.
>> * Across the transition at around Git version 2.0, the user used to
>> get a pretty loud warning when running "git push" without setting
>> push.default configuration variable. We no longer warn, given that
>> the transition is over long time ago.
>
> That last sentence sounds weird... perhaps "the transition was
> completed a long time ago" ? Or "the transition ended a long time
> ago" ?
* ... We no longer warn because the transition was completed a long
time ago.
>> * A slight update to the Makefile to mark "phoney" targets
>> as such correctly.
>
> phoney -> phony?
Thanks for sharp eyes.
>> * Some calls to strcpy(3) triggers a false warning from static
>> analysers that are less intelligent than humans, and reducing the
>> number of these false hits helps us notice real issues. A few
>> calls to strcpy(3) in test-path-utils that are already safe has
>> been rewritten to avoid false wanings.
>>
>> * Some calls to strcpy(3) triggers a false warning from static
>> analysers that are less intelligent than humans, and reducing the
>> number of these false hits helps us notice real issues. A few
>> calls to strcpy(3) in "git rerere" that are already safe has been
>> rewritten to avoid false wanings.
>
> The above two messages are very similar, only the end differs a bit.
That's deliberate as they are two different fixes to a similar
problems. We can just omit the names of the components to make them
into one entry if we really wanted to.
>> * Asking gitweb for a nonexistent commit left a warning in the server
>> log.
>>
>> Somebody may want to follow this up with an additional test, perhaps?
>> IIRC, we do test that no Perl warnings are given to the server log,
>> so this should have been caught if our test coverage were good.
>
> That last paragraph seems odd for a changelog?
I do not think it is wrong to leave a reminder to ourselves that
there are yet more work need to be done.
>> * The underlying machinery used by "ls-files -o" and other commands
>> have been taught not to create empty submodule ref cache for a
>
> have -> has (the machinery is singular)
Again, thanks for sharp eyes.
next prev parent reply other threads:[~2016-03-14 18:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 23:04 [ANNOUNCE] Git v2.8.0-rc2 Junio C Hamano
2016-03-12 9:11 ` Max Horn
2016-03-14 18:10 ` Junio C Hamano [this message]
2016-03-14 15:29 ` Michael J Gruber
2016-03-14 15:30 ` [PATCH] wt-status: allow "ahead " to be picked up by l10n Michael J Gruber
2016-03-14 15:57 ` Junio C Hamano
2016-03-14 15:56 ` [ANNOUNCE] Git v2.8.0-rc2 Junio C Hamano
2016-03-14 17:47 ` Junio C Hamano
2016-03-16 13:33 ` Michael J Gruber
2016-03-16 13:40 ` Duy Nguyen
2016-03-16 15:32 ` Michael J Gruber
2016-03-16 16:30 ` Junio C Hamano
2016-03-17 14:51 ` Michael J Gruber
2016-03-17 15:14 ` [RFC/PATCH] Makefile: allow po generation through po target Michael J Gruber
2016-03-17 22:42 ` Junio C Hamano
2016-03-17 16:15 ` [ANNOUNCE] Git v2.8.0-rc2 Junio C Hamano
2016-03-20 9:45 ` Jiang Xin
2016-03-20 15:11 ` Michael J Gruber
2016-03-21 20:01 ` Junio C Hamano
2016-03-22 10:00 ` Michael J Gruber
2016-03-22 17:43 ` Junio C Hamano
2016-03-15 16:42 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvb4p9bgz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=max@quendi$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox