public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Pranit Bauva <pranit.bauva@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2] t/t7502 : drop duplicate test
Date: Fri, 11 Mar 2016 10:39:56 -0800	[thread overview]
Message-ID: <xmqqvb4samf7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <010201536326c56b-cd751f0b-f03f-4c9f-b834-20cee14b6eb5-000000@eu-west-1.amazonses.com> (Pranit Bauva's message of "Fri, 11 Mar 2016 00:49:58 +0000")

Pranit Bauva <pranit.bauva@gmail•com> writes:

> This extra test was introduced erroneously by
> f9c0181 (t7502: test commit.status, --status and
> --no-status, 2010-01-13)
>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail•com>
> ---

Thanks.  I briefly thought that this might be checking that doing
this twice would give different results, but that is not what is
happening.  Also the remainder of this does cover all the
combinations, so we are OK after applying this patch.

Thanks, will queue.

>  t/t7502-commit.sh | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
> index b39e313..725687d 100755
> --- a/t/t7502-commit.sh
> +++ b/t/t7502-commit.sh
> @@ -527,11 +527,6 @@ try_commit_status_combo () {
>  		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>  	'
>  
> -	test_expect_success 'commit' '
> -		try_commit "" &&
> -		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
> -	'
> -
>  	test_expect_success 'commit --status' '
>  		try_commit --status &&
>  		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>
> --
> https://github.com/git/git/pull/208

     prev parent reply	other threads:[~2016-03-11 18:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 22:12 [PATCH v4] commit: add a commit.verbose config variable Pranit Bauva
2016-03-10 22:39 ` Pranit Bauva
2016-03-10 22:52 ` Junio C Hamano
2016-03-10 23:02   ` Pranit Bauva
2016-03-10 23:01 ` Eric Sunshine
2016-03-11  0:15   ` Pranit Bauva
2016-03-11  5:44     ` Eric Sunshine
2016-03-11  8:00       ` Pranit Bauva
2016-03-11  9:39       ` Roberto Tyley
2016-03-11 10:18     ` Philip Oakley
2016-03-11  0:49 ` [PATCH v2] t/t7502 : drop duplicate test Pranit Bauva
2016-03-11  5:09   ` Pranit Bauva
2016-03-11 18:39   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvb4samf7.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pranit.bauva@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox