From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: Git Users <git@vger•kernel.org>, Jeff King <peff@peff•net>
Subject: Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override
Date: Thu, 28 Jan 2016 14:06:57 -0800 [thread overview]
Message-ID: <xmqqvb6dl5oe.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <AB5433EB-2C86-4A71-9E9F-057AC3CC150A@gmail.com> (Lars Schneider's message of "Thu, 28 Jan 2016 10:27:20 +0100")
Lars Schneider <larsxschneider@gmail•com> writes:
> If the clean/smudge command of a Git filter driver (filter.<driver>.smudge and
> filter.<driver>.clean) is set to an empty string ("") and the filter driver is
> not required (filter.<driver>.required=false) then Git will run successfully.
> However, Git will print an error for every file that is affected by the filter.
>
> Teach Git to consider an empty clean/smudge filter as legitimately disabled
> and do not print an error message if the filter is not required.
That makes more sense to me.
next prev parent reply other threads:[~2016-01-28 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 12:22 [PATCH] convert: legitimately disable clean/smudge filter with an empty override larsxschneider
2016-01-24 15:06 ` Torsten Bögershausen
2016-01-24 21:35 ` Eric Sunshine
2016-01-27 9:49 ` Lars Schneider
2016-01-27 9:42 ` Lars Schneider
2016-01-24 21:45 ` Jeff King
2016-01-27 9:50 ` Lars Schneider
2016-01-25 1:25 ` Junio C Hamano
2016-01-28 9:27 ` Lars Schneider
2016-01-28 22:06 ` Junio C Hamano [this message]
2016-01-28 23:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvb6dl5oe.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox