From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: Jeff King <peff@peff•net>, Git Users <git@vger•kernel.org>,
Fredrik Medley <fredrik.medley@gmail•com>,
patrick.reynolds@github•com
Subject: Re: [PATCH] test: accept death by SIGPIPE as a valid failure mode
Date: Thu, 05 Nov 2015 08:21:53 -0800 [thread overview]
Message-ID: <xmqqvb9g76xq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <457EAFF7-C649-4DEB-BB9E-E82851DC7F8A@gmail.com> (Lars Schneider's message of "Thu, 5 Nov 2015 10:34:53 +0100")
Lars Schneider <larsxschneider@gmail•com> writes:
> Oh, I missed this email thread. I am still working on a stable
> Travis-CI integration and I ran into this issue a few times. I
> fixed it in my (not yet published) patch with an additional
> function "test_must_fail_or_sigpipe" that I've used for all tests
> affected by this issue. Modifying the "test_must_fail" function
> seemed too risky for me as I don't understand all possible
> implications. However, if you don't see a problem then this is
> fine with me.
It's not that I don't see a problem at all. You constructed a good
summary of the issues in three bullet points, that lead me to think
that it is the right approach to tweak the way the tests evaluate
the outcome, but then nothing came out of the discussion, so I sent
out a "how about doing it this way" to make sure this topic will not
be forgotten. There is nothing more to it, and "how about..." is in
no way final.
There obviously are pros and cons between introducing your new
helper to mark the ones that are allowed to catch SIGPIPE and
changing all occurrences of test_must_fail. I do not have a strong
opinion yet, but it needs to be discussed and decided.
prev parent reply other threads:[~2015-11-05 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 13:08 [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky? Lars Schneider
2015-10-25 7:18 ` Fredrik Medley
2015-10-25 13:47 ` Lars Schneider
2015-10-25 17:38 ` Junio C Hamano
2015-10-30 21:00 ` Junio C Hamano
2015-10-30 21:22 ` [PATCH] test: accept death by SIGPIPE as a valid failure mode Junio C Hamano
2015-11-05 7:47 ` Jeff King
2015-11-05 9:34 ` Lars Schneider
2015-11-05 16:21 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvb9g76xq.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=fredrik.medley@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=patrick.reynolds@github$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox