public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Karthik Nayak <karthik.188@gmail•com>
Cc: git@vger•kernel.org, christian.couder@gmail•com,
	Matthieu.Moy@grenoble-inp•fr
Subject: Re: [RFC/PATCH 3/9] for-each-ref: add '--points-at' option
Date: Tue, 09 Jun 2015 12:07:26 -0700	[thread overview]
Message-ID: <xmqqvbew66q9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5576D591.6030704@gmail.com> (Karthik Nayak's message of "Tue, 09 Jun 2015 17:31:21 +0530")

Karthik Nayak <karthik.188@gmail•com> writes:

>>> @@ -54,7 +59,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
>>>   	/* for warn_ambiguous_refs */
>>>   	git_config(git_default_config, NULL);
>>>
>>> -	memset(&ref_cbdata, 0, sizeof(ref_cbdata));
>>
>> I cannot quite see how this change relates to the addition of the
>> new option.
>>
>
> Well if we memset() after calling parse_opt_points_at(), we loose all
> the information we would have obtained.
> So the memset() is moved to an earlier location.

which I did not see, because I expected the code to follow the usual
"no decl-after-statement" pattern.  IOW

>>   	int maxcount = 0, quote_style = 0;
>>   	struct ref_filter_cbdata ref_cbdata;
>> +	memset(&ref_cbdata, 0, sizeof(ref_cbdata));
>>
>>   	struct option opts[] = {
>>   		OPT_BIT('s', "shell", &quote_style,

Don't do that.  Always start your function like so:

	type funcname(args)
        {
        	declarations;

                first statement;
		...

with no blank line within declarations block and a blank line after
the declarations block.

next prev parent reply	other threads:[~2015-06-09 19:07 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-06 20:03 [RFC/PATCH 0/9] add options to ref-filter Karthik Nayak
2015-06-06 20:04 ` [RFC/PATCH 1/9] tag: libify parse_opt_points_at() Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 2/9] ref-filter: implement '--points-at' option Karthik Nayak
2015-06-08 17:31     ` Matthieu Moy
2015-06-08 18:50       ` Karthik Nayak
2015-06-08 18:00     ` Matthieu Moy
2015-06-08 18:54       ` Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 3/9] for-each-ref: add " Karthik Nayak
2015-06-08 17:35     ` Matthieu Moy
2015-06-08 18:51       ` Karthik Nayak
2015-06-08 19:12     ` Junio C Hamano
2015-06-09 12:01       ` Karthik Nayak
2015-06-09 19:07         ` Junio C Hamano [this message]
2015-06-10  6:55           ` Karthik Nayak
2015-06-10  7:39           ` Matthieu Moy
2015-06-10 11:31             ` Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 4/9] parse-options: add parse_opt_merge_filter() Karthik Nayak
2015-06-08 17:58     ` Matthieu Moy
2015-06-08 18:54       ` Karthik Nayak
2015-06-08 19:20     ` Junio C Hamano
2015-06-09 12:36       ` Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 5/9] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-06-08 17:51     ` Matthieu Moy
2015-06-08 18:53       ` Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 6/9] for-each-ref: add " Karthik Nayak
2015-06-08 17:53     ` Matthieu Moy
2015-06-08 18:54       ` Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 7/9] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-06-08 19:32     ` Junio C Hamano
2015-06-09 12:49       ` Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 8/9] ref-filter: add " Karthik Nayak
2015-06-06 20:04   ` [RFC/PATCH 9/9] for-each-ref: " Karthik Nayak
2015-06-08 19:00   ` [RFC/PATCH 1/9] tag: libify parse_opt_points_at() Junio C Hamano
2015-06-09 11:50     ` Karthik Nayak
2015-06-07 13:10 ` [RFC/PATCH 0/9] add options to ref-filter Christian Couder
2015-06-08 15:00   ` Karthik Nayak
2015-06-08 19:34 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbew66q9.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=karthik.188@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox