From: Junio C Hamano <gitster@pobox•com>
To: "René Scharfe" <l.s.r@web•de>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH 1/2] strbuf: export strbuf_addchars()
Date: Mon, 08 Sep 2014 11:32:10 -0700 [thread overview]
Message-ID: <xmqqvboym09h.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <540C0344.9060002@web.de> ("René Scharfe"'s message of "Sun, 07 Sep 2014 09:03:32 +0200")
René Scharfe <l.s.r@web•de> writes:
> Move strbuf_addchars() to strbuf.c, where it belongs, and make it
> available for other callers.
>
> Signed-off-by: Rene Scharfe <l.s.r@web•de>
Wow, fixing up v1.7.0.2~9^2~2?
Both patches look correct, but I have to wonder where you are
drawing these clean-up opportunities from? Almost as if reading
through dormant part of the codebase one of your hobbies or
something ;-)
Jokes aside, I very much appreciate it. Thanks.
next prev parent reply other threads:[~2014-09-08 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 7:03 [PATCH 1/2] strbuf: export strbuf_addchars() René Scharfe
2014-09-07 7:06 ` [PATCH 2/2] strbuf: use strbuf_addchars() for adding a char multiple times René Scharfe
2014-09-08 18:32 ` Junio C Hamano [this message]
2014-09-08 21:36 ` [PATCH 1/2] strbuf: export strbuf_addchars() René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvboym09h.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox