From: Junio C Hamano <gitster@pobox•com>
To: Tanay Abhra <tanayabh@gmail•com>
Cc: git@vger•kernel.org, Ramkumar Ramachandra <artagnon@gmail•com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Subject: Re: [PATCH v10 1/4] string-list: add string_list initializer helper function
Date: Fri, 18 Jul 2014 10:15:15 -0700 [thread overview]
Message-ID: <xmqqvbqumvvg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1405675142-20300-2-git-send-email-tanayabh@gmail.com> (Tanay Abhra's message of "Fri, 18 Jul 2014 02:18:59 -0700")
Tanay Abhra <tanayabh@gmail•com> writes:
> The string-list API has STRING_LIST_INIT_* macros to be used
> to define variables with initializers, but lacks functions
> to initialise an uninitialized piece of memory to be used as
> a string-list at the run-time.
> Introduce `string_list_init()` function for that.
>
> Signed-off-by: Tanay Abhra <tanayabh@gmail•com>
> ---
Looks sensible, modulo s/initialise/initialize/ which perhaps is
originally my fault.
Will queue; thanks.
> Documentation/technical/api-string-list.txt | 5 +++++
> string-list.c | 6 ++++++
> string-list.h | 2 ++
> 3 files changed, 13 insertions(+)
>
> diff --git a/Documentation/technical/api-string-list.txt b/Documentation/technical/api-string-list.txt
> index f1add51..d51a657 100644
> --- a/Documentation/technical/api-string-list.txt
> +++ b/Documentation/technical/api-string-list.txt
> @@ -68,6 +68,11 @@ Functions
>
> * General ones (works with sorted and unsorted lists as well)
>
> +`string_list_init`::
> +
> + Initialize the members of the string_list, set `strdup_strings`
> + member according to the value of the second parameter.
> +
> `filter_string_list`::
>
> Apply a function to each item in a list, retaining only the
> diff --git a/string-list.c b/string-list.c
> index aabb25e..db38b62 100644
> --- a/string-list.c
> +++ b/string-list.c
> @@ -1,6 +1,12 @@
> #include "cache.h"
> #include "string-list.h"
>
> +void string_list_init(struct string_list *list, int strdup_strings)
> +{
> + memset(list, 0, sizeof(*list));
> + list->strdup_strings = strdup_strings;
> +}
> +
> /* if there is no exact match, point to the index where the entry could be
> * inserted */
> static int get_entry_index(const struct string_list *list, const char *string,
> diff --git a/string-list.h b/string-list.h
> index dd5e294..494eb5d 100644
> --- a/string-list.h
> +++ b/string-list.h
> @@ -18,6 +18,8 @@ struct string_list {
> #define STRING_LIST_INIT_NODUP { NULL, 0, 0, 0, NULL }
> #define STRING_LIST_INIT_DUP { NULL, 0, 0, 1, NULL }
>
> +void string_list_init(struct string_list *list, int strdup_strings);
> +
> void print_string_list(const struct string_list *p, const char *text);
> void string_list_clear(struct string_list *list, int free_util);
next prev parent reply other threads:[~2014-07-18 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:18 [PATCH v10 0/4] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-18 9:18 ` [PATCH v10 1/4] string-list: add string_list initializer helper function Tanay Abhra
2014-07-18 17:15 ` Junio C Hamano [this message]
2014-07-18 9:19 ` [PATCH v10 2/4] replace memset with string-list initializers Tanay Abhra
2014-07-18 9:19 ` [PATCH v10 3/4] add `config_set` API for caching config-like files Tanay Abhra
2014-07-18 9:40 ` Matthieu Moy
2014-07-18 9:52 ` Tanay Abhra
2014-07-18 10:03 ` Matthieu Moy
2014-07-18 9:19 ` [PATCH v10 4/4] test-config: add tests for the config_set API Tanay Abhra
2014-07-18 17:01 ` Junio C Hamano
2014-07-18 21:52 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbqumvvg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox