From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Jacob Keller <jacob.e.keller@intel•com>, git@vger•kernel.org
Subject: Re: [PATCH 1/3] tag: use skip_prefix instead of magic numbers
Date: Fri, 11 Jul 2014 11:42:59 -0700 [thread overview]
Message-ID: <xmqqvbr33ff0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140711175056.GE7856@sigill.intra.peff.net> (Jeff King's message of "Fri, 11 Jul 2014 13:50:56 -0400")
Jeff King <peff@peff•net> writes:
> On Fri, Jul 11, 2014 at 10:24:05AM -0700, Jacob Keller wrote:
>
>> Make the parsing of the --sort parameter more readable by having
>> skip_prefix keep our pointer up to date.
>>
>> Authored-by: Jeff King <peff@peff•net>
>
> I suspect Junio may just apply this on the version of the commit he has
> upstream, so you may not need this as part of your series.
You read me correctly ;-) That is what I was planning to do, to
fork jk/tag-sort topic on top of the updated jk/skip-prefix topic.
> However, for reference, the right way to handle authorship is with a
>
> From: Jeff King <peff@peff•net>
>
> at the top of your message body. Git-am will pick that up and turn it
> into the author field of the commit.
Thanks.
next prev parent reply other threads:[~2014-07-11 18:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 17:24 [PATCH 1/3] tag: use skip_prefix instead of magic numbers Jacob Keller
2014-07-11 17:24 ` [PATCH 2/3] tag: fix --sort tests to use cat<<-\EOF format Jacob Keller
2014-07-11 17:24 ` [PATCH 3/3 v5] tag: support configuring --sort via .gitconfig Jacob Keller
2014-07-11 17:46 ` Jeff King
2014-07-11 18:11 ` Keller, Jacob E
2014-07-11 18:22 ` Jeff King
2014-07-11 20:36 ` Keller, Jacob E
2014-07-11 21:54 ` Junio C Hamano
2014-07-11 22:12 ` Keller, Jacob E
2014-07-12 1:17 ` Jeff King
2014-07-13 17:01 ` Junio C Hamano
2014-07-14 22:08 ` Keller, Jacob E
2014-07-11 17:50 ` [PATCH 1/3] tag: use skip_prefix instead of magic numbers Jeff King
2014-07-11 18:04 ` Keller, Jacob E
2014-07-11 18:42 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-11 20:51 Jacob Keller
2014-07-11 21:38 Jacob Keller
2014-07-11 22:44 ` Junio C Hamano
2014-07-11 22:47 ` Keller, Jacob E
2014-07-11 22:55 Jacob Keller
2014-07-12 1:02 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbr33ff0.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox