From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Stepan Kasal <kasal@ucw•cz>,
GIT Mailing-list <git@vger•kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx•de>,
msysGit <msysgit@googlegroups•com>
Subject: Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option
Date: Wed, 14 May 2014 11:33:47 -0700 [thread overview]
Message-ID: <xmqqvbt8jjlg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140514182654.GA9218@google.com> (Jonathan Nieder's message of "Wed, 14 May 2014 11:26:54 -0700")
Jonathan Nieder <jrnieder@gmail•com> writes:
>>> + if (opt.ignore_case && !strcmp("less", pager))
>>> + string_list_append(&path_list, "-i");
>>
>> I have a feeling that this goes against the recent trend of not
>> mucking with the expectation of the users on their pagers, if I
>> recall correctly the arguments for dropping S from the default given
>> to an unconfigured LESS environment variable.
>
> It's just missing an explanation.
> ...
> (That's -I, not -i, because it ought to work even when the pattern
> contains capital letters.)
Spot on. The change, especially with "-I", makes sense.
Thanks.
next prev parent reply other threads:[~2014-05-14 18:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:50 [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option Stepan Kasal
2014-05-14 17:57 ` Junio C Hamano
2014-05-14 18:15 ` Matthieu Moy
2014-05-14 18:26 ` Jonathan Nieder
2014-05-14 18:33 ` Junio C Hamano [this message]
2014-05-15 17:44 ` Johannes Schindelin
2014-05-15 17:53 ` Jonathan Nieder
2014-05-15 19:01 ` Johannes Schindelin
2014-05-15 19:48 ` Junio C Hamano
2014-05-14 18:35 ` Stepan Kasal
2014-05-14 19:07 ` Jeff King
2014-05-15 17:46 ` Johannes Schindelin
2014-05-15 17:56 ` Jonathan Nieder
2014-05-15 19:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbt8jjlg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=jrnieder@gmail$(echo .)com \
--cc=kasal@ucw$(echo .)cz \
--cc=msysgit@googlegroups$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox