From: Junio C Hamano <gitster@pobox•com>
To: Felipe Contreras <felipe.contreras@gmail•com>
Cc: git@vger•kernel.org, John Keeping <john@keeping•me.uk>
Subject: Re: [PATCH 0/4] remote-hg: more improvements
Date: Wed, 07 May 2014 13:28:46 -0700 [thread overview]
Message-ID: <xmqqvbth8ha9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <536a83097302f_76ff7a52ec6c@nysa.notmuch> (Felipe Contreras's message of "Wed, 07 May 2014 14:01:29 -0500")
Felipe Contreras <felipe.contreras@gmail•com> writes:
> Junio C Hamano wrote:
>> Felipe Contreras <felipe.contreras@gmail•com> writes:
>>
>> > Here's a bunch of tests more, and a fixes for Mercurial v3.0.
>>
>> I think the discussion with John Keeping hints that we shouldn't be
>> rushing fc/remote-helpers-hg-bzr-graduation
>
> Really? Based on what reasoning? I have proven his reasoning to be
> basically wrong.
Perhaps s/proven/convinced myself only/; you didn't prove it to me
and I doubt you proved it to John.
>> For example, I see
>>
>> from mercurial import changegroup
>> if check_version(3, 0):
>> cg = changegroup.getbundle(...)
>> else:
>> cg = repo.getbundle(...)
>>
>> and offhand it was unclear if the unconditional import was a
>> mistake.
>
> Of course it wasn't a mistake.
I doubt about the "Of course" part. The first reaction after seeing
that the new "changegroup" is used only inside check_version(3,0)
and nowhere else was to wonder if that import is necessary (or even
safe) for the pre-v3.0 versions.
next prev parent reply other threads:[~2014-05-07 20:28 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 2:16 [PATCH 0/4] remote-hg: more improvements Felipe Contreras
2014-05-04 2:16 ` [PATCH 1/4] remote-hg: add more tests Felipe Contreras
2014-05-04 9:40 ` Eric Sunshine
2014-05-04 2:16 ` [PATCH 2/4] t: remote-hg: add file operation tests Felipe Contreras
2014-05-04 2:16 ` [PATCH 3/4] t: remote-hg: trivial cleanups and fixes Felipe Contreras
2014-05-04 2:16 ` [PATCH 4/4] remote-hg: add support for hg v3.0 Felipe Contreras
2014-05-07 18:12 ` [PATCH 0/4] remote-hg: more improvements Junio C Hamano
2014-05-07 19:01 ` Felipe Contreras
2014-05-07 20:28 ` Junio C Hamano [this message]
2014-05-07 20:37 ` Felipe Contreras
2014-05-07 23:59 ` Junio C Hamano
2014-05-08 1:09 ` Felipe Contreras
2014-05-08 1:34 ` James Denholm
2014-05-08 20:15 ` Felipe Contreras
2014-05-11 19:33 ` Philippe Vaucher
2014-05-12 12:19 ` Philippe Vaucher
2014-05-12 19:50 ` Junio C Hamano
2014-05-12 20:19 ` Felipe Contreras
2014-05-12 20:40 ` Junio C Hamano
2014-05-12 22:21 ` Felipe Contreras
2014-05-14 9:12 ` Philippe Vaucher
2014-05-14 9:30 ` David Kastrup
2014-05-14 9:36 ` Philippe Vaucher
2014-05-14 9:55 ` David Kastrup
2014-05-14 12:11 ` Philippe Vaucher
2014-05-14 12:50 ` David Kastrup
2014-05-14 13:13 ` Philippe Vaucher
2014-05-14 13:51 ` David Kastrup
2014-05-14 16:06 ` Philippe Vaucher
2014-05-14 20:19 ` Felipe Contreras
2014-05-14 20:58 ` David Kastrup
2014-05-14 21:39 ` Felipe Contreras
2014-05-14 22:12 ` David Kastrup
2014-05-14 22:30 ` Felipe Contreras
2014-05-15 6:03 ` David Kastrup
2014-05-14 22:24 ` Junio C Hamano
2014-05-14 22:30 ` David Kastrup
2014-05-14 22:34 ` Junio C Hamano
2014-05-08 0:00 ` Junio C Hamano
2014-05-08 1:36 ` Felipe Contreras
2014-05-08 18:36 ` Junio C Hamano
2014-05-08 19:56 ` Felipe Contreras
2014-05-08 22:22 ` Junio C Hamano
2014-05-08 22:42 ` Felipe Contreras
2014-05-08 23:06 ` Junio C Hamano
2014-05-08 23:39 ` Felipe Contreras
2014-05-09 0:23 ` Felipe Contreras
2014-05-09 17:16 ` Junio C Hamano
2014-05-09 17:59 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbth8ha9.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=john@keeping$(echo .)me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox