From: Junio C Hamano <gitster@pobox•com>
To: Felipe Contreras <felipe.contreras@gmail•com>
Cc: Ilya Bobyr <ilya.bobyr@gmail•com>, git@vger•kernel.org
Subject: Re: [RTC/PATCH] Add 'update-branch' hook
Date: Wed, 23 Apr 2014 15:15:06 -0700 [thread overview]
Message-ID: <xmqqvbtzwv4l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53583111dd8ad_24448772ec17@nysa.notmuch> (Felipe Contreras's message of "Wed, 23 Apr 2014 16:30:57 -0500")
Felipe Contreras <felipe.contreras@gmail•com> writes:
> Junio C Hamano wrote:
>> Felipe Contreras <felipe.contreras@gmail•com> writes:
>>
>> > ... there are _already_ hooks without pre/post.
>>
>> Like commit-msg? Yes, it would have been nicer if it were named
>> verify-commit-message or something.
>
> No it wouldn't. I can use the commit-msg hook to change the commit message and
> to absolutely no verification, so verify-commit-message would be misleading.
You are confused (and please do not spread the confusion). If you
read the first paragraph of the documentation on the hook and think
for 5 seconds why "--no-verify" countermands it, you would realize
that the hook is primarily meant for verification. We also allow
the hook to edit the message, but that is not even "a useful feature
added as an afterthought"; the documentation mentions it because the
implementation did not bother to make sure the hook did not touch
the message file.
It was a mistake not to call it with a clear name that tells
verification happens there.
>> Old mistakes are harder to change because of inertia. It is not a
>> good excuse to knowingly make a new mistake to add new exceptions
>> that the users need to check documentations for, is it?
I see no reason to waste more time on this point.
next prev parent reply other threads:[~2014-04-23 22:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 2:23 [RTC/PATCH] Add 'update-branch' hook Felipe Contreras
2014-04-21 7:25 ` Eric Sunshine
2014-04-21 20:02 ` Ilya Bobyr
2014-04-21 20:49 ` Felipe Contreras
2014-04-21 21:15 ` Ilya Bobyr
2014-04-21 21:17 ` Felipe Contreras
2014-04-21 21:39 ` Ilya Bobyr
2014-04-21 21:36 ` Felipe Contreras
2014-04-22 14:43 ` Stephen Leake
2014-04-22 16:31 ` Felipe Contreras
2014-04-22 17:09 ` Ilya Bobyr
2014-04-22 17:28 ` Felipe Contreras
2014-04-23 7:49 ` Stephen Leake
2014-04-23 9:07 ` Felipe Contreras
2014-04-23 22:44 ` Junio C Hamano
2014-04-24 1:11 ` Felipe Contreras
2014-04-26 17:38 ` Junio C Hamano
2014-04-26 19:28 ` Felipe Contreras
2014-04-24 14:26 ` Stephen Leake
2014-04-24 18:08 ` Felipe Contreras
2014-04-21 21:52 ` Junio C Hamano
2014-04-21 22:26 ` Felipe Contreras
2014-04-21 23:00 ` Junio C Hamano
2014-04-23 21:30 ` Felipe Contreras
2014-04-23 22:15 ` Junio C Hamano [this message]
2014-04-24 1:00 ` Felipe Contreras
2014-04-22 6:41 ` Ilya Bobyr
2014-04-22 16:30 ` Felipe Contreras
2014-04-21 21:17 ` Ilya Bobyr
2014-04-21 21:15 ` Felipe Contreras
2014-04-21 21:36 ` Ilya Bobyr
2014-04-21 21:35 ` Felipe Contreras
[not found] ` <CADcHDF+XcWEkvyP3tL4ibicnaMVJpixUZu1Ces0BXWkzPGsodw@mail.gmail.com>
2014-04-21 22:24 ` Felipe Contreras
2014-04-22 6:05 ` Ilya Bobyr
2014-04-22 6:45 ` Felipe Contreras
2014-04-22 7:00 ` Ilya Bobyr
2014-04-22 6:56 ` Felipe Contreras
2014-04-22 6:35 ` Ilya Bobyr
2014-04-22 16:27 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbtzwv4l.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ilya.bobyr@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox