From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] pack-objects: do not reuse packfiles without --delta-base-offset
Date: Mon, 07 Apr 2014 10:15:43 -0700 [thread overview]
Message-ID: <xmqqvbulm56o.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140404231301.GA2528@sigill.intra.peff.net> (Jeff King's message of "Fri, 4 Apr 2014 19:13:01 -0400")
Jeff King <peff@peff•net> writes:
> On Fri, Apr 04, 2014 at 03:28:48PM -0700, Junio C Hamano wrote:
> ...
>> OK, together with the fact that only ancient versions of fetcher
>> would trigger this "do not reuse" codepath, I agree that we should
>> go the simplest route this patch takes.
>
> By the way, we may want to revisit this if we grow more features that do
> not allow straight byte-for-byte reuse.
True.
> I am thinking specifically if we
> grow a packv4-like representation for an object, and we plan to convert
> on-the-fly to existing packv2 clients. But I think the sensible steps
> for that are:
>
> 1. If we have v4 on disk and are outputting v2, add this case to the
> "can_reuse" function I just added. I.e., start out correct, and
> turn off the optimization.
>
> 2. Experiment with on-the-fly conversion. It may be that the
> conversion is so expensive that the reuse optimization gets lost in
> the noise. Or maybe we can reclaim most of the advantage of the
> reuse code path, and it is worth going object-by-object and
> converting. But we won't know until we can measure.
Yeah; I think these are sensible steps in the future direction.
Thanks.
prev parent reply other threads:[~2014-04-07 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 6:39 [PATCH] pack-objects: do not reuse packfiles without --delta-base-offset Jeff King
2014-04-02 17:39 ` Junio C Hamano
2014-04-04 21:48 ` Jeff King
2014-04-04 22:28 ` Junio C Hamano
2014-04-04 23:13 ` Jeff King
2014-04-07 17:15 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbulm56o.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox