From: Junio C Hamano <gitster@pobox•com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: git@vger•kernel.org, jrnieder@gmail•com, peff@peff•net
Subject: Re: [PATCH 1/3] patch-id: make it stable against hunk reordering
Date: Thu, 27 Mar 2014 09:58:41 -0700 [thread overview]
Message-ID: <xmqqvbuzefy6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1395912239-29663-1-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 27 Mar 2014 11:25:06 +0200")
"Michael S. Tsirkin" <mst@redhat•com> writes:
> Patch id changes if you reorder hunks in a diff.
If you reorder hunks, the patch should no longer apply [*1*], so a
feature to make patch-id stable across such move would have no
practical use ;-), but I am guessing you meant something else.
Perhaps this is about using "-O <orderfile>" option, even though you
happened to have implemented the id mixing at per-hunk level?
[Footnote]
*1* It has been a long time since I looked at the code, and I do not
know offhand if "git apply" has such a bug not to diagnose a hunk
for a file for an earlier part that comes later in its input stream
after seeing another hunk for the same file as a bug. If it does
not, perhaps we should.
next prev parent reply other threads:[~2014-03-27 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 9:25 [PATCH 1/3] patch-id: make it stable against hunk reordering Michael S. Tsirkin
2014-03-27 9:25 ` [PATCH 2/3] patch-id: document new behaviour Michael S. Tsirkin
2014-03-27 9:25 ` [PATCH 3/3] patch-id-test: test new --stable and --unstable flags Michael S. Tsirkin
2014-03-28 0:25 ` Eric Sunshine
2014-03-27 16:58 ` Junio C Hamano [this message]
2014-03-27 17:34 ` [PATCH 1/3] patch-id: make it stable against hunk reordering Michael S. Tsirkin
2014-03-27 17:57 ` Michael S. Tsirkin
2014-03-27 18:03 ` Junio C Hamano
2014-03-27 18:39 ` Michael S. Tsirkin
2014-03-27 18:45 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbuzefy6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox