public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Linus Torvalds <torvalds@linux-foundation•org>,
	Tejun Heo <tj@kernel•org>, Git Mailing List <git@vger•kernel.org>,
	Jeff King <peff@peff•net>
Subject: Re: Re* [RFC PATCH 2/1] Make request-pull able to take a refspec of form local:remote
Date: Thu, 13 Mar 2014 14:22:00 -0700	[thread overview]
Message-ID: <xmqqvbvhhk07.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cQTRFgbbyXsWraNTbL+nOY2y09KEJPfGc3wynFA+RWswQ@mail.gmail.com> (Eric Sunshine's message of "Wed, 12 Mar 2014 19:18:44 -0400")

Eric Sunshine <sunshine@sunshineco•com> writes:

>> +Prepare a request to your upstream project to pull your changes to
>> +their tree to the standard output, by summarizing your changes and
>> +showing where your changes can be pulled from.
>
> Perhaps splitting this into two sentence (and using fewer to's) would
> make it a bit easier to grok? Something like:
>
>     Generate a request asking your upstream project to pull changes
>     into their tree. The request, printed to standard output,
>     summarizes the changes and indicates from where they can be
>     pulled.

Thanks.

>> +When the repository named by `<url>` has the commit at a tip of a
>> +ref that is different from the ref you have it locally, you can use
>
> Did you want to drop "it" from this sentence? Or did you mean to say
> "the ref as you have it locally"?

Thanks for your careful reading.  Will drop "it".

     prev parent reply	other threads:[~2014-03-13 21:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23  0:06 [RFC PATCH 2/1] Make request-pull able to take a refspec of form local:remote Linus Torvalds
2014-01-23 19:43 ` Junio C Hamano
2014-01-23 19:57   ` Linus Torvalds
2014-01-23 22:58     ` Junio C Hamano
2014-01-23 23:56       ` Linus Torvalds
2014-01-24 20:16         ` Junio C Hamano
2014-01-29 23:34           ` Re* " Junio C Hamano
2014-01-30  0:16             ` brian m. carlson
2014-01-30  0:40             ` Linus Torvalds
2014-02-25 21:44               ` Junio C Hamano
2014-03-12 18:04                 ` Junio C Hamano
2014-03-12 23:18                   ` Eric Sunshine
2014-03-13 21:22                     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbvhhk07.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=sunshine@sunshineco$(echo .)com \
    --cc=tj@kernel$(echo .)org \
    --cc=torvalds@linux-foundation$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox